Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All done, message when maximum number of translation is reached. #22

Open
EfrosIonelu opened this issue Sep 16, 2022 · 1 comment
Open
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@EfrosIonelu
Copy link

Showing "All done." on push

When you have this message on https://localise.biz/

"This account is using the maximum 5,000 translations available on the Pro plan."

is actually a bug.

@robrechtme robrechtme added bug Something isn't working good first issue Good for newcomers labels Sep 17, 2022
@VNDRN
Copy link
Contributor

VNDRN commented Sep 9, 2024

I looked into this
I don't think this is something we can "fix" ourselves, as we get a 200 OK result back from the push.
A workaround is that we throw an error if after the push, the remote and local files are not in sync. A quick mockup could be:

 ...
 progressbar.stop();

  // check if it's all good
  const updatedRemote = await apiPull(accessKey, pullOptions);
  const { totalCount: updatedTotalCount, deletedCount: updatedDeletedCount } = diff(
    updatedRemote,
    local,
    pushOptions
  );

  if (updatedTotalCount || updatedDeletedCount) {
    log.error('Something went wrong, please check any logs in the Localise dashboard.');
    process.exit(1);
  }

 log.warn('Be kind to your translators');
...

Is this something we'd like to add @robrechtme?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants