New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor getAbsolutePath helper #110

Open

lizell opened this issue May 20, 2016 · 0 comments

Labels

Member

lizell commented May 20, 2016 •

edited

Loading

https://github.com/rocjs/roc/blob/master/src/helpers/index.js#L13

Quoting @dlmr:

I think the right thing here might be to update getAbsolutePath so that it does not return undefined when filepath is undefined but instead either process.cwd() or the directory that was provided to it. Seems like this is the expected result in the code but I will need to look a little closer to be 100% sure if we decide to go down this path.

See #109 https://github.com/rocjs/roc/pull/109/files/f7db8d6cee52ba07d8cfced813ff938b7a8a061b#r63885705 for background.

lizell added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment