fix: ordering of excluding keys for safe json

rocket-connect · Sep 1, 2023 · 0a73b7c · 0a73b7c
1 parent 3858dc9
commit 0a73b7c
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 17 deletions.
diff --git a/graphql-otel.com/package-lock.json b/graphql-otel.com/package-lock.json
diff --git a/package/package-lock.json b/package/package-lock.json
diff --git a/package/package.json b/package/package.json
@@ -1,6 +1,6 @@
 {
   "name": "graphql-otel",
-  "version": "0.1.8",
+  "version": "0.1.9",
   "description": "Opentelemetry GraphQL Schema Directives.",
   "main": "./dist/index.js",
   "types": "./dist/index.d.ts",

diff --git a/package/src/utils.ts b/package/src/utils.ts
@@ -13,22 +13,21 @@ export const excludedKeys = [
   "_result",
 ];
 
-export function safeJson(object: any) {
-  const safeJSON = JSON.stringify(object || {}, (key, value) => {
+export function safeJson(object: any = {}) {
+  const obj = { ...object };
+  excludedKeys.forEach((key) => {
+    delete obj[key];
+  });
+
+  return safeJsonStringify(obj, (key, value) => {
     if (typeof value === "bigint") {
       return value.toString();
     }
 
-    if (excludedKeys.includes(key)) {
-      return undefined;
-    }
-
     if (typeof value === "function") {
       return "Function";
     }
 
     return value;
   });
-
-  return safeJsonStringify(JSON.parse(safeJSON));
 }