Change in the order of instructions executed in the UserSchema 'save' middleware && Changes in globalErrorHandler.

Author: rodyherrera

server/controllers/globalErrorHandler.js

@@ -35,7 +35,7 @@ const parseError = (err) => {
         TokenExpiredError: { message: 'JWT::Expired', statusCode: 401 },
         MongoServerError: (code) => { 
           if(code === 11000) return { message: 'Database::Duplicated::Fields', statusCode: 400 };
-          return { message: 'Database:Error', statusCode: 500 };
+          return { message: err.message, statusCode: err.statusCode };
         }
     };
     const handler = errorMap[err.name] || errorMap.MongoServerError; 
@@ -54,7 +54,6 @@ const parseError = (err) => {
 const errorHandler = (err, req, res, next) => {
     err.statusCode = err.statusCode || 500;
     err.message = err.message || 'Server Error';
-    console.log('[Quantum Cloud] @globalErrorHandler:', err);
     if(err instanceof RuntimeError){
         return res.status(err.statusCode).send({ status: 'error', message: err.message });
     }

server/models/user.js

@@ -107,9 +107,12 @@ UserSchema.pre('findOneAndDelete', async function(){
     });
 });
 
-// DOCKER CONTAINER IS CREATED IF ERROR EXISTS
 UserSchema.pre('save', async function(next){
     try{
+        if(!this.isModified('password')) return next();
+        this.username = this.username.replace(/\s/g, '');
+        this.password = await bcrypt.hash(this.password, 12);
+        this.passwordConfirm = undefined;
         // The existence of "global.logStreamStore" is checked 
         // because it is an object that is created when the server runs. 
         // However, when you run the CLI and choose the "Create new user" 
@@ -127,11 +130,6 @@ UserSchema.pre('save', async function(next){
                 console.log(`[Quantum Cloud] CRITICAL ERROR (at @models/user - pre save middleware): ${error}`)
             });
         }
-        if(!this.isModified('password')) return next();
-        this.username = this.username.replace(/\s/g, '');
-        this.password = await bcrypt.hash(this.password, 12);
-        this.passwordConfirm = undefined;
-        
         if(!this.isModified('password') || this.isNew) return next();
         this.passwordChangedAt = Date.now() - 1000;
         next();