Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RollbarReactNative not available on CocoaPods, but other Rollbar pods are #198

Open
camsjams opened this issue Oct 3, 2024 · 3 comments · May be fixed by #200
Open

RollbarReactNative not available on CocoaPods, but other Rollbar pods are #198

camsjams opened this issue Oct 3, 2024 · 3 comments · May be fixed by #200

Comments

@camsjams
Copy link

camsjams commented Oct 3, 2024

Hello!

I was trying to get this library working for React Native on iOS via Expo (have it working great on Android in prod already 👍 ), but hit a snag.

As you can see these pods are available on the CocoaPods dependency site:

Problem

But for some reason, the primary Rollbar pod is not there:
https://cocoapods.org/pods/RollbarReactNative

Thus, when installing via CocoaPods, and with tools like Expo, I see errors like so:

Adding spec repo `trunk` with CDN `https://cdn.cocoapods.org/`
CocoaPods 1.15.0 is available.
...
// numerous successful installs
...
Installing RollbarCommon (3.3.2)
Installing RollbarCrash (3.3.2)
Installing RollbarNotifier (3.3.2)
Installing RollbarReactNative (1.0.0-beta.4)
[!] Error installing RollbarReactNative
[!] /usr/bin/git clone https://github.com/rollbar/rollbar-react-native.git /var/folders/vn/nzbsghpn733f46w61_gbp33r0000gn/T/d20241002-1429-nr65g1 --template= --single-branch --depth 1 --branch 1.0.0-beta.4
Cloning into '/var/folders/vn/nzbsghpn733f46w61_gbp33r0000gn/T/d20241002-1429-nr65g1'...
warning: Could not find remote branch 1.0.0-beta.4 to clone.
fatal: Remote branch 1.0.0-beta.4 not found in upstream origin

I've also tried 1.0.0-beta.3 fwiw, but given that the pod link 404s, I think this is just not published on CocoaPods (not sure how that works ha).

More Info

I tried the printed git clone command from above error and this seems to also give a clue:

git clone https://github.com/rollbar/rollbar-react-native.git --template= --single-branch --depth 1 --branch 1.0.0-beta.4

Begets:

Cloning into 'rollbar-react-native'...
warning: Could not find remote branch 1.0.0-beta.4 to clone.
fatal: Remote branch 1.0.0-beta.4 not found in upstream origin

Expo Related Info

This is likely derived from this config in the app.config for expo:

      [
        "expo-build-properties",
        {
          "ios": {
            "deploymentTarget": "14.0",
            "useFrameworks": "static",
            "extraPods": [
              {
                "name": "RollbarReactNative",
                "podspec": "../node_modules/rollbar-react-native/RollbarReactNative.podspec"
              },
              {
                "name": "RollbarReport",
                "modular_headers": true
              },
              {
                "name": "RollbarCrash",
                "modular_headers": true
              }
            ]
          }
        }
      ]
@camsjams
Copy link
Author

camsjams commented Oct 4, 2024

I think this line in the podspec:

s.source = { :git => 'https://github.com/rollbar/rollbar-react-native.git', :tag => '1.0.0-beta.4' }

Should actually include the v prefix for the version:

  s.source       = { :git => 'https://github.com/rollbar/rollbar-react-native.git', :tag => 'v1.0.0-beta.4' }

@camsjams camsjams linked a pull request Oct 5, 2024 that will close this issue
12 tasks
@camsjams
Copy link
Author

camsjams commented Oct 5, 2024

Yep that was the issue, I added a PR for this #200

@waltjones
Copy link
Contributor

Hi @camsjams , thank you for the report and the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants