Skip to content

Commit f668025

Browse files
authored
Restore TruffleRuby on CI (#256)
* Fix specs on TruffleRuby and Remove TruffleRuby specific expectations in specs
1 parent b76b833 commit f668025

File tree

2 files changed

+7
-22
lines changed

2 files changed

+7
-22
lines changed

.github/workflows/ruby.yml

+1-2
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@ jobs:
1313
- '3.2'
1414
- '3.3'
1515
# - jruby
16-
# NOTE: temporarily disable truffleruby due to weird rspec issue
17-
# - truffleruby
16+
- truffleruby
1817
name: Ruby ${{ matrix.ruby }}
1918
steps:
2019
- uses: actions/checkout@v4

spec/cli/commands/dns_proxy_spec.rb

+6-20
Original file line numberDiff line numberDiff line change
@@ -124,16 +124,9 @@
124124
let(:name) { '/[abc/' }
125125

126126
it "must raise an OptionParser::InvalidArgument" do
127-
# XXX: TruffleRuby's RegexpError exception message is different
128-
if RUBY_ENGINE == 'truffleruby'
129-
expect {
130-
subject.parse_record_name(name)
131-
}.to raise_error(OptionParser::InvalidArgument,"invalid argument: invalid Regexp: premature end of char-class (org.joni.exception.SyntaxException): /[abc/")
132-
else
133-
expect {
134-
subject.parse_record_name(name)
135-
}.to raise_error(OptionParser::InvalidArgument,"invalid argument: invalid Regexp: premature end of char-class: /[abc/")
136-
end
127+
expect {
128+
subject.parse_record_name(name)
129+
}.to raise_error(OptionParser::InvalidArgument,"invalid argument: invalid Regexp: premature end of char-class: /[abc/")
137130
end
138131
end
139132
end
@@ -196,16 +189,9 @@
196189
let(:name) { '/[abc/' }
197190

198191
it "must raise an OptionParser::InvalidArgument" do
199-
# XXX: TruffleRuby's RegexpError exception message is different
200-
if RUBY_ENGINE == 'truffleruby'
201-
expect {
202-
subject.parse_rule(rule)
203-
}.to raise_error(OptionParser::InvalidArgument,"invalid argument: invalid Regexp: premature end of char-class (org.joni.exception.SyntaxException): /[abc/")
204-
else
205-
expect {
206-
subject.parse_rule(rule)
207-
}.to raise_error(OptionParser::InvalidArgument,"invalid argument: invalid Regexp: premature end of char-class: /[abc/")
208-
end
192+
expect {
193+
subject.parse_rule(rule)
194+
}.to raise_error(OptionParser::InvalidArgument,"invalid argument: invalid Regexp: premature end of char-class: /[abc/")
209195
end
210196
end
211197
end

0 commit comments

Comments
 (0)