Add compatibility with current version of DataFrames #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @hhaensel ! No, we cannot do this. PrettyTables v3 has a completely different API. We need to finish v3, tag it, and update DataFrames to become compatible. In the mean time, PrettyTables v3 will not be able to be used at the same time with DataFrames. Unfortunately, Julia packaging system does not allow for loading two versions of the same package at the same time. |
|
Fair enough, thanks for commenting. I read that integration with DataFrames is advancing, so looking forward to seeing the final implementation 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently v3 of PrettyTables cannot be tested together with the latest version of DataFrames.
In this PR I have added some modifications that remedy this situation. This fix is not perfect, some arguments in the text backend get lost, because I couldn't find out how to treat them properly.
I am aware that this is compromising the new type system, but maybe it's something that can be applied for the first version of v3 for a transition period, as this will certainly affect more packages than DataFrames.
@ronisbr Happy to hear what you think.