[Typst] Add TypstCaption type for improved legends, disambiguate text attributes, and support table-level parameters
#295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ronan Arraes Jardim Chagas <[email protected]>
Co-authored-by: Ronan Arraes Jardim Chagas <[email protected]>
Co-authored-by: Ronan Arraes Jardim Chagas <[email protected]>
Co-authored-by: Ronan Arraes Jardim Chagas <[email protected]>
…c23-sudo/PrettyTables.jl into tests/enhance-coverage
Tests/enhance coverage
remove temporary test string
1. Add a space between comma and pareters 2. Add `max_num_char_line` * break function calls in multiple lines
added 9 commits
January 21, 2026 16:56
ronisbr
requested changes
Jan 24, 2026
| end | ||
|
|
||
| """ | ||
| """ |
Owner
There was a problem hiding this comment.
Add documentation for the function or remove this docstring.
| struct Percent <: TypstRelativeLengthKind end | ||
| struct Auto end | ||
|
|
||
| Base.show(io::IO,::Auto) = print(io,"auto") |
Owner
There was a problem hiding this comment.
Always add space after comma in function declaration and function calling.
| position:: Union{Nothing,String} | ||
| end | ||
|
|
||
| function TypstCaption(caption; kind=Auto(), |
Owner
There was a problem hiding this comment.
This function is not following the Blue Style convention.
| il -= 1 | ||
|
|
||
| if !isnothing(caption) | ||
| if !isnothing(caption) |
| # ---------------------------------------------------------------------------- | ||
| # 1) Text attribute filter: only keeps `text-*` keys that map to _TYPST__TEXT_ATTRIBUTES | ||
| # ---------------------------------------------------------------------------- | ||
| @testset "_typst__filter_text_atributes" verbose=true begin |
Owner
There was a problem hiding this comment.
Indentation must always use 4 spaces in Julia code.
Owner
|
Thanks @gustavohtc23-sudo ! I completed the review with just a few formatting issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a set of improvements to the Typst backend aimed at clarity, expressiveness, and better alignment with Typst’s table API.
Main changes
Add
TypstCaptiontype to enable more explicit and semantically meaningful legends, improving readability and extensibility.Disambiguate text-related attributes by prefixing all attributes that apply exclusively to text with text-, eliminating ambiguity with table- or cell-level attributes.
Add support for table-level parameters accepted by Typst table, allowing structured configuration at the table level instead of relying on implicit or cell-scoped settings.
Motivation
Explicit legend kinds make the output easier to integrate with another sources of tables and images.
The text-* prefix clarifies intent and reduces naming conflicts in styling options.
Exposing Typst table parameters at the table level improves ergonomics and feature parity with Typst.
Compatibility notes
Attribute renaming to text-* may affect existing code; this PR updates internal usage accordingly.
If desired, deprecations or aliases for previous attribute names can be added in a follow-up.
Tests and documentation
Tests were updated/added to cover the new Kind field, text-* attributes, and table-level parameters.
Examples were adjusted to reflect the new API where applicable.
Feedback on naming, scope, or compatibility strategy is very welcome.
Closes #293
Closes #294