Skip to content

Commit 6da38db

Browse files
committed
Adjust single drawObjectTitle function
1 parent 6142645 commit 6da38db

File tree

4 files changed

+35
-43
lines changed

4 files changed

+35
-43
lines changed

modules/draw/TGraphPolarPainter.mjs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -496,12 +496,13 @@ class TGraphPolarPainter extends ObjectPainter {
496496
return true;
497497
}
498498

499+
/** @summary Draw TGraphPolar title */
499500
async drawTitle(first_time) {
500501
return drawObjectTitle(this, first_time, this._draw_axis, !this.getObject()?.TestBit(kNoTitle));
501502
}
502503

503504
/** @summary Redraw TGraphPolar */
504-
redraw() {
505+
async redraw() {
505506
return this.drawGraphPolar()
506507
.then(() => this.drawTitle());
507508
}

modules/draw/TPiePainter.mjs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -360,6 +360,7 @@ class TPiePainter extends ObjectPainter {
360360
});
361361
}
362362

363+
/** @summary Draw TPie title */
363364
async drawTitle(first_time) {
364365
return drawObjectTitle(this, first_time, !this.options.same, true);
365366
}

modules/hist/TPavePainter.mjs

Lines changed: 31 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -1821,62 +1821,52 @@ class TPavePainter extends ObjectPainter {
18211821
} // class TPavePainter
18221822

18231823

1824-
/** @summary Only redraw object title
1825-
* @return {Promise} with painter */
1826-
async function updateObjectTitle(painter, is_enabled, is_draw) {
1827-
// case when histogram drawn over other histogram (same option)
1828-
if (!is_enabled)
1829-
return painter;
1830-
1831-
const tpainter = painter.getPadPainter()?.findPainterFor(null, kTitle, clTPaveText),
1832-
pt = tpainter?.getObject();
1833-
1834-
if (!tpainter || !pt)
1835-
return painter;
1836-
1837-
const obj = painter.getObject(),
1838-
draw_title = is_draw && (gStyle.fOptTitle > 0);
1839-
1840-
pt.Clear();
1841-
if (draw_title)
1842-
pt.AddText(obj.fTitle);
1843-
return tpainter.redraw().then(() => painter);
1844-
}
1845-
18461824
/** @summary Draw object title
18471825
* @return {Promise} with painter */
18481826
async function drawObjectTitle(painter, first_time, is_enabled, is_draw) {
18491827
if (!is_enabled)
18501828
return painter;
18511829

1852-
if (!first_time)
1853-
return updateObjectTitle(painter, is_enabled, is_draw);
1830+
const st = gStyle,
1831+
obj = painter.getObject(),
1832+
pp = painter.getPadPainter(),
1833+
draw_title = is_draw && (st.fOptTitle > 0);
1834+
1835+
if (first_time) {
1836+
let pt = pp.findInPrimitives(kTitle, clTPaveText);
1837+
if (pt) {
1838+
pt.Clear();
1839+
if (draw_title)
1840+
pt.AddText(obj.fTitle);
1841+
return painter;
1842+
}
18541843

1855-
const obj = painter.getObject(), st = gStyle,
1856-
draw_title = is_draw && (st.fOptTitle > 0),
1857-
pp = painter.getPadPainter();
1844+
pt = create(clTPaveText);
1845+
Object.assign(pt, {
1846+
fName: kTitle, fOption: 'blNDC', fFillColor: st.fTitleColor, fFillStyle: st.fTitleStyle, fBorderSize: st.fTitleBorderSize,
1847+
fTextFont: st.fTitleFont, fTextSize: st.fTitleFontSize, fTextColor: st.fTitleTextColor, fTextAlign: 22
1848+
});
18581849

1859-
let pt = pp.findInPrimitives(kTitle, clTPaveText);
1860-
if (pt) {
1861-
pt.Clear();
18621850
if (draw_title)
18631851
pt.AddText(obj.fTitle);
1864-
return painter;
1852+
1853+
return TPavePainter.draw(pp, pt, kPosTitle).then(p => {
1854+
p?.setSecondaryId(painter, kTitle);
1855+
return painter;
1856+
});
18651857
}
18661858

1867-
pt = create(clTPaveText);
1868-
Object.assign(pt, {
1869-
fName: kTitle, fOption: 'blNDC', fFillColor: st.fTitleColor, fFillStyle: st.fTitleStyle, fBorderSize: st.fTitleBorderSize,
1870-
fTextFont: st.fTitleFont, fTextSize: st.fTitleFontSize, fTextColor: st.fTitleTextColor, fTextAlign: 22
1871-
});
1859+
const tpainter = pp?.findPainterFor(null, kTitle, clTPaveText),
1860+
pt = tpainter?.getObject();
1861+
1862+
if (!tpainter || !pt)
1863+
return painter;
18721864

1865+
pt.Clear();
18731866
if (draw_title)
18741867
pt.AddText(obj.fTitle);
1875-
1876-
return TPavePainter.draw(pp, pt, kPosTitle).then(p => {
1877-
p?.setSecondaryId(painter, kTitle);
1878-
return painter;
1879-
});
1868+
return tpainter.redraw().then(() => painter);
18801869
}
18811870

1871+
18821872
export { TPavePainter, kPosTitle, drawObjectTitle };

modules/hist2d/THistPainter.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1671,7 +1671,7 @@ class THistPainter extends ObjectPainter {
16711671

16721672
/** @summary Only redraw histogram title
16731673
* @return {Promise} with painter */
1674-
async updateHistTitle(first_time = false) {
1674+
async updateHistTitle(first_time) {
16751675
const o = this.getOptions(),
16761676
histo = this.getHisto();
16771677
return drawObjectTitle(this, first_time, this.isMainPainter() && !o.Same && (o.Axis <= 0), !histo.TestBit(kNoTitle));

0 commit comments

Comments
 (0)