Do not explicitely create batch display when not configured

linev · linev · commit efa6602b4a54 · 2025-11-25T12:50:00.000+01:00
diff --git a/modules/gui/HierarchyPainter.mjs b/modules/gui/HierarchyPainter.mjs
@@ -3609,7 +3609,7 @@ class HierarchyPainter extends BasePainter {
          delete this.disp;
       }
 
-      if ((this.disp_kind === 'batch') || !this.disp_frameid || isNodeJs()) {
+      if (this.disp_kind === 'batch') {
          const pr = isNodeJs() ? _loadJSDOM() : Promise.resolve(null);
          return pr.then(handle => {
             this.disp = new BatchDisplay(1200, 800, handle?.body);
@@ -3618,7 +3618,7 @@ class HierarchyPainter extends BasePainter {
       }
 
       // check that we can found frame where drawing should be done
-      if (!document.getElementById(this.disp_frameid))
+      if (!this.disp_frameid || !document.getElementById(this.disp_frameid))
          return null;
 
       if (isBatchMode())

Original file line number	Diff line number	Diff line change
`@@ -3609,7 +3609,7 @@ class HierarchyPainter extends BasePainter {`
`3609`	`3609`	`delete this.disp;`
`3610`	`3610`	`}`
`3611`	`3611`
`3612`		`- if ((this.disp_kind === 'batch') \|\| !this.disp_frameid \|\| isNodeJs()) {`
	`3612`	`+ if (this.disp_kind === 'batch') {`
`3613`	`3613`	`const pr = isNodeJs() ? _loadJSDOM() : Promise.resolve(null);`
`3614`	`3614`	`return pr.then(handle => {`
`3615`	`3615`	`this.disp = new BatchDisplay(1200, 800, handle?.body);`
`@@ -3618,7 +3618,7 @@ class HierarchyPainter extends BasePainter {`
`3618`	`3618`	`}`
`3619`	`3619`
`3620`	`3620`	`// check that we can found frame where drawing should be done`
`3621`		`- if (!document.getElementById(this.disp_frameid))`
	`3621`	`+ if (!this.disp_frameid \|\| !document.getElementById(this.disp_frameid))`
`3622`	`3622`	`return null;`
`3623`	`3623`
`3624`	`3624`	`if (isBatchMode())`