Implement reorder of segments in http requests #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Idea to resort and merge ranges before submitting to http server
While such fallback appears in several places - implement it in send new request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analyze requested ranges and do following:
This allows to reduce data traffic and avoids problem of different implementations on server side.
Some servers does such merging themselves. Or does resorting under the hoot.
There are many ROOT files where streamer info and main directory key situated together -
so one can read both of them now with single http request instead of multi-range ones.
In connected issue #372 this allows to reduce number of requests - while server does not support multirange requests at all.
Also this PR solves VERY OLD problem with tbits3 example, where unsorted segments in request leads to wrong reply from the server. In JSROOT special handling was implemented to abort such request and restart with single range requests. So now multi-range works properly and very fast for this old file.