-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RDF] support bar charts in RDataFrame #17057
Comments
This is an interesting feature request: thanks. The current formulation seems to hint to the need of it to modernise a tutorial. The cost benefit ratio, as it stands, does not seem too favourable. Would the feature also address an explicit need of ROOT's users? |
@dpiparo the only user case I'm aware of is the forum thread linked above by @will-cern |
Hello @vepadulano I would love to help on this feature request... |
Hi @Aditya-138-12 ! Thanks for reaching out. Would you like to try to propose a PR, test coverage and an example of this functionality? |
Hi, @dpiparo ! yeah sure, working on it!! |
Hi @Aditya-138-12 did you encounter difficulties? |
Hi @dpiparo, @vepadulano , @martamaja10 Could you kindly guide me on which files to modify to integrate this into ROOT? Thank you for your time and support! |
Hi @vepadulano @dpiparo @martamaja10 I wanted to follow up on this. I’ve implemented bar chart functionality for supporting alphanumeric bins in Could you kindly guide me on which files I should modify to integrate this into ROOT? I would really appreciate your insights. Thank you for your time and support! |
Feature description
It would be nice if RDataFrame supported bar charts (aka TH[123] with alphanumeric bins). Currently there is a way to achieve it with a user-defined helper, but having a native API would be helpful.
Internally the helper should probably use a TH1L to store the count of occurrences for the column.
Alternatives considered
No response
Additional context
This would allow modernizing tutorials such as this and avoid the use of TTree::Draw
The text was updated successfully, but these errors were encountered: