Skip to content

remove link to Mozilla review guide? #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
maelle opened this issue Aug 23, 2024 · 2 comments · Fixed by #893
Closed

remove link to Mozilla review guide? #835

maelle opened this issue Aug 23, 2024 · 2 comments · Fixed by #893
Labels
content 📃

Comments

@maelle
Copy link
Member

maelle commented Aug 23, 2024

Or keep it as a reference, but inline what we want reviewers to take away from it?
@maelle maelle pinned this issue Feb 3, 2025
@maelle
Copy link
Member Author

maelle commented Feb 25, 2025

more generally, we need more guidance on reviewing for reviewers and editors, here and in pkgreviewr. cc @mpadge

@maelle
Copy link
Member Author

maelle commented Feb 25, 2025

we could mention reprex (for examples in reviews)

@maelle maelle mentioned this issue Mar 11, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
content 📃
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improve reviewing guide ropensci/dev_guide
1 participant
@maelle