You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current error messages are not informative in the absence of credentials,
i.e. I get Error in curl::curl_fetch_memory(url, handle = handle) : <url> malformed
if I run project_list() now without credentials.
If there's no system variables set and no credentials passed either,
the functions should fail with an informative error message.
The text was updated successfully, but these errors were encountered:
It's probably time to bite the ckanr_setup/ckanr_settings apple I've avoided so far:
get_odkc_{test_}{url, un, pw}() to wrap Sys.getenv("ODKC_{TEST_}{URL, UN,PW}") as standard args for functions, e.g. project_list(url = get_odkc_url(), un = get_odkc_un(), ...)
ruODK_setup(url="xxx", un="yyy", pw="zzz", test_url="...", test_un="...", test_pw="...") to wrap Sys.setenv(ODKC_{TEST_}{URL, UN, PW})
That would be an opportunity to make ruODK yell loudly but clearly about missing credentials.
florianm
changed the title
Include meaningful error message on missing settings including credentials
Make settings fun again - including loud bit intelligible yelling if missing
Aug 29, 2019
florianm
changed the title
Make settings fun again - including loud bit intelligible yelling if missing
Make settings fun again - including loud but intelligible yelling if something is missing
Aug 29, 2019
Add getters and setter for settings, tests, docs.
Convert project_* and related tests to use settings getters as defaults.
TODO convert remaining functions.
Add getters and setter for settings, tests, docs.
Convert project_* and related tests to use settings getters as defaults.
TODO convert remaining functions.
Feature
All functions using settings should fail with a meaningful error message.
Source ropensci/software-review#335 @maelle
The text was updated successfully, but these errors were encountered: