Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing methods, lead-through, module / program loading #126

Open
dorianleveque opened this issue Nov 22, 2020 · 2 comments
Open

Add missing methods, lead-through, module / program loading #126

dorianleveque opened this issue Nov 22, 2020 · 2 comments

Comments

@dorianleveque
Copy link

Hi everyone,

I recently worked on the robot Yumi (from ABB company) for a project of my school and I noticed during the development that some method was not implemented. In particular, I needed to control the lead-through and to be able to load a module and programme remotely to give position instructions to the arm joints using RAPID code.

By consulting the documentation I found out that it was simple to add the missing methods in the client and interface files.
So that's what I did and I was able to test my code on a simulator (RobotStudio) and on the real robot and it works as shown in the following videos:

Can I make a pull request ?

@gavanderhoorn
Copy link
Member

I'll let @jontje comment on the utility of your proposed contributions, but from a process point of view: please open PRs, preferable 1 PR per feature (or more, if it would make reviewing easier).

It's much easier to figure out whether something would make sense to merge here if the code can be inspected, and having it as a PR immediately facilitates discussion.

If in the end it's decided to not merge a PR: no problem, we just close it.

@jontje
Copy link
Contributor

jontje commented Nov 23, 2020

Hi @dorianleveque,

Can I make a pull request ?

Yes, you are more than welcome to create a PR, but please split it up into separate PRs as @gavanderhoorn indicated.

I will be happy to review the contributions, but just so you know, then I will be fairly preoccupied with year-end deadlines and demos until at least mid-December.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants