Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose getSignals() in RWSInterface. #66

Open
de-vri-es opened this issue Oct 30, 2019 · 0 comments
Open

Expose getSignals() in RWSInterface. #66

de-vri-es opened this issue Oct 30, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@de-vri-es
Copy link
Contributor

PR #63 adds RWSClient::getSignals() to retrieve all signals from a controller. However, it doesn't expose the function in RWSInterface yet. This should still be done.

Quoted from @jontje:

Do you also intend to expose the new function in the more user-friendly RWSInterface class? For example:

* Implementing a `struct` for an IO-signal list item according to the [documentation](http://developercenter.robotstudio.com/blobproxy/devcenter/Robot_Web_Services/html/ios_signals_get_page.html), which contains:
  
  * name: IO-signal name
  * type: Signal type {DO | DI | AO | AI | GI | GO}
  * category: Signals list item
  * lvalue: Signal value
  * lstate: Signals state {simulated | not simulated}

* Parsing the XML document into a vector of such IO-signal list items, similar to [RWSInterface::getRAPIDModulesInfo(...)](https://github.com/ros-industrial/abb_librws/blob/master/src/rws_interface.cpp#L233-L250).

If not, can you open an issue for that?

Can you also update the PR to be in sync with the base branch?

@de-vri-es de-vri-es changed the title Expose getSignals() in RWSInterface. Expose getSignals() in RWSInterface. Oct 30, 2019
@gavanderhoorn gavanderhoorn added the enhancement New feature or request label May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants