Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fcntl porting for windows #14

Open
stonier opened this issue Mar 14, 2013 · 2 comments
Open

fcntl porting for windows #14

stonier opened this issue Mar 14, 2013 · 2 comments

Comments

@stonier
Copy link
Member

stonier commented Mar 14, 2013

The former is a linux only piece of code. Can't even import fctnl. I don't know exactly what is the equivalent code yet. Problem is in here:

https://github.com/ros/ros/blob/groovy-devel/core/roslib/src/roslib/network.py

Why did we not have this problem in fuerte though? There is branching there:

if _use_netifaces:
  # maybe this one got hit.
elif _is_unix_like_platform():
  # fcntl code
else():
  # single interface fallback
  • Q) Why is windows falling into _is_unix_like_platform()?
  • Q) Maybe it fell into the first option in fuerte?
@ghost ghost assigned stonier Mar 14, 2013
@stonier
Copy link
Member Author

stonier commented Mar 14, 2013

Ah, this is important (same file):

# disabling netifaces as it accounts for 50% of startup latency

@stonier
Copy link
Member Author

stonier commented Mar 14, 2013

So we should be in the last branch where you can find this comment:

 # cross-platform branch, can only resolve one address

Maybe a future problem?

@stonier stonier removed their assignment Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant