Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arch dependent paths #27

Open
richmattes opened this issue Jul 4, 2016 · 1 comment
Open

Arch dependent paths #27

richmattes opened this issue Jul 4, 2016 · 1 comment

Comments

@richmattes
Copy link

It looks like #26 updated the code to install the cmake module configs to arch dependent paths based on checks that the cmake package version script is making.

The problem is that urdfdom-headers really is architecture independent, and making it architecture dependent doesn't really buy you anything. It just makes it harder to package.

I think the better solution would have been to disable the architecture check instead of updating the install path. The documentation recommends using custom confg-version.pc.in instead of using the helpers if the version checks should be altered. It also looks like you can work around the version checks in the default templates by adding set(CMAKE_SIZEOF_VOID_P "") to CMakeLists.txt. That seems to work in my testing, but it's a little bit hacky.

I filed a bug against cmake to add an option to disable the architecture check, but any changes there won't help in the near term

Also, the pkg-config file is being installed to lib/pkgconfig. It's also architecture independent, so it should be going to share/pkgconfig.

@scpeters
Copy link
Contributor

scpeters commented Jul 6, 2016

cc @j-rivero

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants