Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport performance improvements to Foxy #657

Closed
7 tasks
emersonknapp opened this issue Feb 16, 2021 · 3 comments
Closed
7 tasks

Backport performance improvements to Foxy #657

emersonknapp opened this issue Feb 16, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@emersonknapp
Copy link
Collaborator

emersonknapp commented Feb 16, 2021

Description

Discussion overview at https://discourse.ros.org/t/fast-forward-merging-rosbag2-master-api-to-foxy/18927

Summary: major performance improvements on master make rosbag2 usable, compared to the Foxy release. This ticket tracks getting the performance improvement onto the Foxy branch (one way or another).

The https://github.com/ros2/rosbag2/tree/foxy-future branch exists with all development up to mid-March 2021, and can be built from source for users who want all improvements

For the default user who installs from APT, however, we want to do the best we can to provide them some of the performance improvements that were discovered.

Related Issues

Completion Criteria

Backport the following PRs, without breaking API/ABI, to Foxy and get it into a sync release. Some may prove difficult and need re-writing on the Foxy branch, this is OK to target a more minimal patch improvement into the stable distro.

Testing Notes / Suggestions

All existing test suites should run and the build should have no test failures or compiler warnings on the build farm.

@emersonknapp
Copy link
Collaborator Author

Updated issue description with a concrete list of PRs to backport

@ros-discourse
Copy link

This issue has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/fast-forward-merging-rosbag2-master-api-to-foxy/18927/49

@emersonknapp emersonknapp removed their assignment Aug 4, 2022
@emersonknapp
Copy link
Collaborator Author

Closed with foxy-future branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants