Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small error section 3.2.6 - Varying color #55

Open
jabarragann opened this issue Oct 4, 2020 · 2 comments
Open

small error section 3.2.6 - Varying color #55

jabarragann opened this issue Oct 4, 2020 · 2 comments

Comments

@jabarragann
Copy link

Hi all,

I think there is an error on the fragment shader program of section 3.2.6. It should be using the previously declared variable "v_color" not "color"

image

@jabarragann
Copy link
Author

jabarragann commented Oct 4, 2020

Just realized that #49 also pointed out the same mistake. However, when I tried to do the PR as you requested, I was not able to find the error on the source code. Both the book.html and the 03-quickstart.rst file don't have this error.

The error is only appearing in the book version in https://www.labri.fr/perso/nrougier/python-opengl/#varying-color.

So it might be fixed by uploading a newer version. (Not exactly sure of how to book is generated from source)

I can help you out doing the PR if you think there is any other file that needs to be changed.

@rougier
Copy link
Owner

rougier commented Oct 12, 2020

Thanks for the report. It may have been already corrected but the website is not up to date with GitHub soures (I have to built it manually).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants