Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Hi @rpaschoal want to add video button on top of ng-chat Window like ng-chat-options #111

Open
Code-N-K opened this issue Apr 4, 2019 · 8 comments

Comments

@Code-N-K
Copy link

Code-N-K commented Apr 4, 2019

I need to add a video button on top of ng-chat Window like Close button. This video button could be click able. Please provide details for the same.

... ng-chat-options to add people i want to add video button and want to call my own functions of javascript and webrtc

@rpaschoal - Enhancement required.

@Code-N-K Code-N-K changed the title Hi @rpaschoal Hi @rpaschoal want to add video button on top of ng-chat Window Apr 4, 2019
@Code-N-K Code-N-K changed the title Hi @rpaschoal want to add video button on top of ng-chat Window Hi @rpaschoal want to add video button on top of ng-chat Window ng-chat-options Apr 4, 2019
@Code-N-K Code-N-K changed the title Hi @rpaschoal want to add video button on top of ng-chat Window ng-chat-options Hi @rpaschoal want to add video button on top of ng-chat Window like ng-chat-options Apr 4, 2019
@rpaschoal
Copy link
Owner

Hi @Code-N-K ,

I believe it would be sufficient if you could provide your extra chat options as an Input right?

@Code-N-K
Copy link
Author

Code-N-K commented Apr 5, 2019

Can you(@rpaschoal ) suggest me the functional code as i was unable to find proper tags in your ng-chat module.

@rpaschoal
Copy link
Owner

rpaschoal commented Apr 5, 2019

Hi @Code-N-K , I believ that is not yet available as public API to the component. Check this link: https://github.com/rpaschoal/ng-chat/blob/master/src/ng-chat/core/chat-option.ts

Do you believe that exposing something similar would help you achieving what you're trying to implement? This is what's being used to render the top right options menu.

@Code-N-K
Copy link
Author

Code-N-K commented Apr 6, 2019

Hi @rpaschoal, it is just an interface. But I need the actual code to add a new button on user message chat window.

My main query is I need to add some more buttons on user chat window, so that we can add our more functionality to the user message chat window.

As you have added the (add people) functionality in your live demo, I am unable to add something like that..

So I actually need to add a(video call) icon near to X(close) button on user message chat window.

@rpaschoal
Copy link
Owner

This is exactly what I am talking about @Code-N-K ,

For the time being that chat options feature is not publicly exposed, it is just used as an internal component in ng-chat. I believe what you want is to be able to pass your own custom options with their own custom actions. This is not implemented yet but it could be.

Would you feel comfortable pushing these changes to this repository and if they look good I'll merge them and publish a new release?

Cheers!

@Code-N-K
Copy link
Author

Code-N-K commented Apr 8, 2019

I am unable to extent the ChatOptions as dont have any example for the same. I can only fork if some working example is available.

i have forked the fesm5 : ng-chat.js file and added the

<a href="javascript:void(0);" class="ng-chat-close primary-text" (click)="onVideoChatWindow(window)">Video\r\n <a href="javascript:void(0);" class="ng-chat-close primary-text" (click)="onCloseChatWindow(window)">X10\r\n

onVideoChatWindow(window) - But the custom method is not working, as it is not part of ng-chat.html

I urgently need this options, Kindly update. @rpaschoal

HELP.

@neeraj-anand
Copy link

Any update on adding video call icon?

@neeraj-anand
Copy link

@rpaschoal Any update on adding video call icon?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants