Skip to content

Commit af0373d

Browse files
committed
feat: always mark generated classes as final/sealed
Removes [finalize: bool] configuration parameter and instead makes it the default.
1 parent 4774262 commit af0373d

File tree

11 files changed

+55
-223
lines changed

11 files changed

+55
-223
lines changed

packages/_internal/lib/models.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,6 @@ class Data with _$Data {
102102
required GenericsParameterTemplate genericsParameterTemplate,
103103
required bool shouldUseExtends,
104104
required bool genericArgumentFactories,
105-
required bool shouldMarkSealedOrFinal,
106105
}) = _Data;
107106
}
108107

packages/_internal/lib/models.freezed.dart

Lines changed: 7 additions & 30 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/freezed/lib/src/freezed_generator.dart

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,6 @@ class FreezedGenerator extends ParserGenerator<GlobalData, Data, Freezed> {
146146
genericsParameterTemplate: GenericsParameterTemplate.fromGenericElement(
147147
declaration.declaredElement!.typeParameters,
148148
),
149-
shouldMarkSealedOrFinal: configs.finalize!,
150149
);
151150
}
152151

@@ -599,11 +598,6 @@ class FreezedGenerator extends ParserGenerator<GlobalData, Data, Freezed> {
599598
orElse: () => _buildYamlConfigs.fromJson,
600599
),
601600
addImplicitFinal: annotation.getField('addImplicitFinal')!.toBoolValue()!,
602-
finalize: annotation.decodeField(
603-
'finalize',
604-
decode: (obj) => obj.toBoolValue(),
605-
orElse: () => _buildYamlConfigs.finalize,
606-
),
607601
map: annotation.decodeField(
608602
'map',
609603
decode: (obj) {

packages/freezed/lib/src/models.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,6 @@ class Data with _$Data {
9292
required GenericsParameterTemplate genericsParameterTemplate,
9393
required bool shouldUseExtends,
9494
required bool genericArgumentFactories,
95-
required bool shouldMarkSealedOrFinal,
9695
}) = _Data;
9796
}
9897

packages/freezed/lib/src/models.freezed.dart

Lines changed: 8 additions & 30 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/freezed/lib/src/templates/concrete_template.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ ${copyWith?.concreteImpl(constructor.parameters) ?? ''}
6464
/// @nodoc
6565
$jsonSerializable
6666
${constructor.decorators.join('\n')}
67-
${data.shouldMarkSealedOrFinal ? 'final' : ''} class $concreteName${data.genericsDefinitionTemplate} $_concreteSuper {
67+
final class $concreteName${data.genericsDefinitionTemplate} $_concreteSuper {
6868
$_concreteConstructor
6969
7070
$_concreteFromJsonConstructor
@@ -86,7 +86,7 @@ $_toJson
8686
}
8787
8888
89-
${data.shouldMarkSealedOrFinal ? 'sealed' : 'abstract'} class ${constructor.redirectedName}${data.genericsDefinitionTemplate} $_superKeyword ${data.name}${data.genericsParameterTemplate}$interfaces {
89+
sealed class ${constructor.redirectedName}${data.genericsDefinitionTemplate} $_superKeyword ${data.name}${data.genericsParameterTemplate}$interfaces {
9090
$_isConst factory ${constructor.redirectedName}(${constructor.parameters.asExpandedDefinition}) = $concreteName${data.genericsParameterTemplate};
9191
$_privateConcreteConstructor
9292

0 commit comments

Comments
 (0)