Skip to content

Commit e5a7ba5

Browse files
committed
fix: freezed_missing_mixin on private types due to leading underscore
Private types get their leading underscore stripped off, but the lint wasn't accounting for that, so it would end up trying to change the type name to one that does not actually exist.
1 parent 542dce4 commit e5a7ba5

File tree

3 files changed

+225
-1
lines changed

3 files changed

+225
-1
lines changed
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
import 'package:freezed_annotation/freezed_annotation.dart';
2+
3+
part 'mixin_name.freezed.dart';
4+
5+
@freezed
6+
class _FooModel with _$FooModel {
7+
const factory _FooModel() = __FooModel;
8+
}

packages/freezed_lint/example/lib/mixin_name.freezed.dart

Lines changed: 214 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/freezed_lint/lib/src/missing_mixin.dart

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,9 @@ class MissingMixin extends DartLintRule {
2424
final annotation = freezedAnnotationChecker.hasAnnotationOfExact(element);
2525
if (!annotation) return;
2626

27-
final name = '_\$${element.name}';
27+
final name = element.name.startsWith('_')
28+
? '_\$${element.name.substring(1)}'
29+
: '_\$${element.name}';
2830
final withClause = node.withClause;
2931
if (withClause == null) {
3032
reporter.atElement(element, _code, arguments: [name]);

0 commit comments

Comments
 (0)