Ensure attributes _and_ length are identical in gradethis_equal.list() (#354)

Author: rossellhayes

R/gradethis_equal.R

@@ -66,14 +66,19 @@ gradethis_equal.list <- function(
     NextMethod()
   }
 
-  # First check if the lengths are the same
+  # First check with `identical()`, since it's fast
+  if (identical(x, y)) {
+    return(TRUE)
+  }
+
+  # Then check if the lengths are the same
   if (length(x) != length(y)) {
     return(FALSE)
   }
 
-  # Then check with `identical()`, since it's fast
-  if (identical(x, y)) {
-    return(TRUE)
+  # Then check if the attributes are the same
+  if (!identical(attributes(x), attributes(y))) {
+    return(FALSE)
   }
 
   # If `identical()` returned `FALSE`, map over each element individually,

tests/testthat/test-gradethis_equal.R

@@ -1,3 +1,7 @@
+test_that("gradethis_equal.list() checks names", {
+  expect_false(gradethis_equal(list(pi, letters), list(a = pi, b = letters)))
+})
+
 test_that("gradethis_equal uses methods from ggcheck", {
   skip_if_not_installed("ggcheck", "0.0.5")
   skip_if_not_installed("ggplot2")