Skip to content

Commit fb57758

Browse files
authored
Merge pull request #702 from rstudio/chronicle-server-address-discovery-fixes
Chronicle agent server address fixes
2 parents a50aa6e + 73022ec commit fb57758

File tree

12 files changed

+37
-12
lines changed

12 files changed

+37
-12
lines changed

charts/rstudio-connect/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: rstudio-connect
22
description: Official Helm chart for Posit Connect
3-
version: 0.8.9
3+
version: 0.8.10
44
apiVersion: v2
55
appVersion: 2025.09.0
66
icon: https://rstudio.com/wp-content/uploads/2018/10/RStudio-Logo-Flat.png

charts/rstudio-connect/NEWS.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
# Changelog
22

3+
## 0.8.10
4+
5+
- Skip `rstudio-library` template call when `chronicleAgent.autoDiscovery=false`. Require `chronicleAgent.serverAddress`
6+
to be set instead.
7+
38
## 0.8.9
49

510
- Bump Connect version to 2025.09.0

charts/rstudio-connect/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Posit Connect
22

3-
![Version: 0.8.9](https://img.shields.io/badge/Version-0.8.9-informational?style=flat-square) ![AppVersion: 2025.09.0](https://img.shields.io/badge/AppVersion-2025.09.0-informational?style=flat-square)
3+
![Version: 0.8.10](https://img.shields.io/badge/Version-0.8.10-informational?style=flat-square) ![AppVersion: 2025.09.0](https://img.shields.io/badge/AppVersion-2025.09.0-informational?style=flat-square)
44

55
#### _Official Helm chart for Posit Connect_
66

@@ -30,11 +30,11 @@ To ensure reproducibility in your environment and insulate yourself from future
3030

3131
## Installing the chart
3232

33-
To install the chart with the release name `my-release` at version 0.8.9:
33+
To install the chart with the release name `my-release` at version 0.8.10:
3434

3535
```{.bash}
3636
helm repo add rstudio https://helm.rstudio.com
37-
helm upgrade --install my-release rstudio/rstudio-connect --version=0.8.9
37+
helm upgrade --install my-release rstudio/rstudio-connect --version=0.8.10
3838
```
3939

4040
To explore other chart versions, look at:

charts/rstudio-connect/templates/deployment.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,11 @@ spec:
118118
{{- end }}
119119
env:
120120
- name: CHRONICLE_SERVER_ADDRESS
121+
{{- if .Values.chronicleAgent.autoDiscovery }}
121122
value: {{ include "rstudio-library.chronicle-agent.serverAddress" (dict "chronicleAgent" .Values.chronicleAgent "Release" .Release) | trim | quote }}
123+
{{- else }}
124+
value: {{ required "chronicleAgent.serverAddress must be specified if autoDiscovery is disabled." .Values.chronicleAgent.serverAddress | quote }}
125+
{{- end }}
122126
- name: CHRONICLE_CONNECT_APIKEY
123127
{{- if .Values.chronicleAgent.connectApiKey.valueFrom }}
124128
valueFrom:

charts/rstudio-library/Chart.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ apiVersion: v2
22
name: rstudio-library
33
description: Helm library helpers for use by official RStudio charts
44
type: library
5-
version: 0.1.34
6-
appVersion: 0.1.34
5+
version: 0.1.35
6+
appVersion: 0.1.35
77

88
icon: https://rstudio.com/wp-content/uploads/2018/10/RStudio-Logo-Flat.png
99
home: https://www.rstudio.com

charts/rstudio-library/NEWS.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
# Changelog
22

3+
# 0.1.35
4+
5+
- Fix `rstudio-library.chronicle-agent.serverAddress` failure when lookup returns none.
6+
- Fail `rstudio-library.chronicle-agent.serverAddress` if no server address could be resolved.
7+
38
## 0.1.34
49

510
- Add HTTP/HTTPS protocol prefix to `rstudio-library.chronicle-agent.serverAddress` function return.

charts/rstudio-library/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# rstudio-library
22

3-
![Version: 0.1.34](https://img.shields.io/badge/Version-0.1.34-informational?style=flat-square) ![Type: library](https://img.shields.io/badge/Type-library-informational?style=flat-square) ![AppVersion: 0.1.34](https://img.shields.io/badge/AppVersion-0.1.34-informational?style=flat-square)
3+
![Version: 0.1.35](https://img.shields.io/badge/Version-0.1.35-informational?style=flat-square) ![Type: library](https://img.shields.io/badge/Type-library-informational?style=flat-square) ![AppVersion: 0.1.35](https://img.shields.io/badge/AppVersion-0.1.35-informational?style=flat-square)
44

55
#### _Helm library helpers for use by official RStudio charts_
66

charts/rstudio-library/templates/_chronicle-agent.tpl

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,13 +39,15 @@ Takes a dict:
3939
{{- define "rstudio-library.chronicle-agent.serverAddress" }}
4040
{{- if .chronicleAgent.serverAddress }}
4141
{{- .chronicleAgent.serverAddress }}
42-
{{- else }}
42+
{{- else if lookup "v1" "Service" (default .Release.Namespace .chronicleAgent.serverNamespace) "" }}
4343
{{- range $index, $service := (lookup "v1" "Service" (default .Release.Namespace .chronicleAgent.serverNamespace) "").items }}
4444
{{- $name := get $service.metadata.labels "app.kubernetes.io/name" }}
4545
{{- $component := get $service.metadata.labels "app.kubernetes.io/component" }}
4646
{{- if and (eq $name "posit-chronicle") (eq $component "server") }}
4747
{{- (index $service.spec.ports 0).name }}://{{ $service.metadata.name }}.{{ $service.metadata.namespace }}
4848
{{- end }}
4949
{{- end }}
50+
{{- else }}
51+
{{- fail "Unable to resolve a Chronicle server address for Chronicle agent. Ensure that a Chronicle server is deployed in the same namespace as this chart or the namespace is specfied with chronicleAgent.serverNamespace when using chronicleAgent.autoDiscovery=true. Alternatively, specify chronicleAgent.serverAddress in the values.yaml file." }}
5052
{{- end }}
5153
{{- end }}

charts/rstudio-workbench/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: rstudio-workbench
22
description: Official Helm chart for Posit Workbench
3-
version: 0.9.13
3+
version: 0.9.14
44
apiVersion: v2
55
appVersion: 2025.09.1
66
icon: https://rstudio.com/wp-content/uploads/2018/10/RStudio-Logo-Flat.png

charts/rstudio-workbench/NEWS.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
# Changelog
22

3+
## 0.9.14
4+
5+
- Skip `rstudio-library` template call when `chronicleAgent.autoDiscovery=false`. Require `chronicleAgent.serverAddress`
6+
to be set instead.
7+
38
## 0.9.13
49

510
- Bump Workbench version to 2025.09.1

0 commit comments

Comments
 (0)