Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove notebooks-enabled=1 from jupyter.conf #610

Open
fh-mthomson opened this issue Nov 13, 2024 · 0 comments
Open

Remove notebooks-enabled=1 from jupyter.conf #610

fh-mthomson opened this issue Nov 13, 2024 · 0 comments

Comments

@fh-mthomson
Copy link
Contributor

In the 2024.09.0 Workbench release notes, Jupyter Hub support is being removed, by default:

Added support for Jupyter Notebook 7. (rstudio-pro#6266)
Replaced code server binary with PWB Code Server. PWB Code Server is bundled with the PWB VS Code Extension, so a separate install is no longer required. It is a fork of VS Code 1.93.0. (rstudio-pro#6265)
In VS Code sessions, Workbench now preserves the open directory or workspace on a per-session basis. (rstudio-pro#6491)
Fixed an issue preventing potential data leakage between users in the same browser session. (vscode-server#17)
Disabled Jupyter Notebooks by default on fresh installs of PWB. (rstudio-pro#6269)

Correspondingly, the product default for notebooks-enabled is 0 - docs

Accordingly, I'd propose updating the values in the helm charts to align: https://github.com/search?q=repo%3Arstudio%2Fhelm%20notebooks-enabled&type=code

Impact: We had removed our setting for notebooks-enabled to leverage the default of 0; but, it was still unexpectedly being set to 1, since we're leveraging Posit's Helm charts as a starting point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant