Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compression format AVHuff not supported #69

Open
edc71 opened this issue Jan 11, 2022 · 6 comments
Open

Compression format AVHuff not supported #69

edc71 opened this issue Jan 11, 2022 · 6 comments

Comments

@edc71
Copy link

edc71 commented Jan 11, 2022

AVHuff is the format used for laserdisks.. its used since v3 afaik

@edc71 edc71 changed the title AVHuff not supported Compression format AVHuff not supported Jan 11, 2022
@rtissera
Copy link
Owner

@edc71 you're right.
I could add AVHuff support for sure but I have to find a way to not bloat too much libchdr which is meant to be easily embeddable in other projects with a small footprint.

@Sanaki
Copy link
Contributor

Sanaki commented Jan 11, 2022

Could always be optional support. If compiled with support, include requisite lib. That way it's available for projects that need it, but doesn't muss up those that don't. Though I suppose that does run contrary to recent efforts to make libchdr more uniform. Hrm.

@rtissera
Copy link
Owner

I agree with you @Sanaki meanwhile I had a look at AVHuff, hopefully it only depends on (possibly) flac which is already in through dr_flac and some huffman decoder so that's not a lot of code.
Worth having a look implementing it.
@edc71 what's the typical use case ? Daphne / Hypseus Singe ?

@Sanaki
Copy link
Contributor

Sanaki commented Jan 11, 2022

Seems like it, though I asked him to open this issue when the topic arose while looking at usage of libchdr with RomVault for data validation purposes. Obviously MAME would be a use case, though I'm not sure under what circumstances this library would come into use with it offhand.

@edc71
Copy link
Author

edc71 commented Jan 12, 2022

I agree with you @Sanaki meanwhile I had a look at AVHuff, hopefully it only depends on (possibly) flac which is already in through dr_flac and some huffman decoder so that's not a lot of code. Worth having a look implementing it. @edc71 what's the typical use case ? Daphne / Hypseus Singe ?

Its actually for a tool which enters rominfo into a database. But hashing chd isnt enough, because the dats are using different hashes. So I needed something simple to include. And also like Sanaki said, it is also been looked at for usage in RomVault

@rtissera
Copy link
Owner

rtissera commented Jan 12, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants