Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cop idea: Prefer #be_within over #round #1705

Open
ydakuka opened this issue Sep 4, 2023 · 0 comments
Open

Cop idea: Prefer #be_within over #round #1705

ydakuka opened this issue Sep 4, 2023 · 0 comments

Comments

@ydakuka
Copy link

ydakuka commented Sep 4, 2023

Describe the solution you'd like

# bad
expect(result.value.round(3)).to eq max_value

# good
expect(result.value).to be_within(0.001).of(max_value)

Rubocop

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop -V
1.55.1 (using Parser 3.2.2.3, rubocop-ast 1.29.0, running on ruby 2.7.8) [x86_64-linux]
  - rubocop-capybara 2.18.0
  - rubocop-factory_bot 2.23.1
  - rubocop-performance 1.18.0
  - rubocop-rails 2.20.2
  - rubocop-rake 0.6.0
  - rubocop-rspec 2.23.0
  - rubocop-thread_safety 0.5.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant