MaxRetry with {} Queue Option Argument throwing Nil Error

[anuonifade]

When Using a MaxRetry handler option for Queues and Queue Option argument is an empty hash, it throws an error.

name = "sample-max-retry"
opts[:queue_options] = {:durable=>true, :auto_delete=>false, :exclusive=>false, :arguments=>{}}
Sneakers::Handlers::Maxretry.configure_queue(
  name,
  opts
)

The line

kicks/lib/sneakers/handlers/maxretry.rb

Line 87 in 185b51c

opt_args = opts[:queue_options][:arguments] ? opts[:queue_options][:arguments].inject({}){|memo,(k,v)| memo[k.to_sym] = v; memo} : {}

will throw an error.

opts[:queue_options][:arguments] ? will return true and trying to inject and empty hash will raise an error.

Changing the line

opt_args = opts[:queue_options][:arguments] ? opts[:queue_options][:arguments].inject({}){|memo,(k,v)| memo[k.to_sym] = v; memo} : {}

To

opt_args = opts[:queue_options][:arguments].blank? ?  {} :  opts[:queue_options][:arguments].inject({}){|memo,(k,v)| memo[k.to_sym] = v; memo}

Should fix the issue.

[michaelklishin]

Feel free to submit a PR. Thank you.

[michaelklishin]

opt_args = opts[:queue_options][:arguments].blank? ?  {} :  opts[:queue_options][:arguments].inject({}){|memo,(k,v)| memo[k.to_sym] = v; memo}

should probably be

opt_args = if opts[:queue_options][:arguments].blank?
             {}
           else
             opts[:queue_options][:arguments].transform_keys(&:to_sym)
           end

[anuonifade]

Yeah, that looks ruby like. It is also important to note that transform_keys was introduced in ruby 2.5 so any lower version of ruby might not work

[michaelklishin]

@anuonifade Bunny and Kicks require 2.5 and arguably should require 2.7. Should have done it a couple of years ago, in fact.

[michaelklishin]

Addressed in #22 by @anuonifade and @texpert.