Skip to content

Update rubocop-on-rbs to v1.7.0 #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025
Merged

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Jun 3, 2025

All corrections are due to RBS/Layout/EmptyLineBetweenDeclarations.

Copy link

github-actions bot commented Jun 3, 2025

@ksss Thanks for your contribution!

Please follow the instructions below for each change.
See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

  • /merge: Merge this PR if CI passes

activerecord

You changed RBS files for an existing gem.
You can merge this PR yourself because you are a reviewer of this gem.
Just comment /merge to merge this PR.

You can also request a review from other reviewers if you want.


bcrypt

You changed RBS files for an existing gem.
This gem does not have reviewers. So you can merge this PR immediately if the CI passes.
We recommend you add yourself to the reviewers for this gem.


sidekiq-ent

You changed RBS files for an existing gem.
You need to get approval from the reviewers of this gem.

@rhiroe, please review this pull request.
If this change is acceptable, please make a review comment including APPROVE from here.
Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR.
Just comment /merge to merge this PR.


sidekiq-pro

You changed RBS files for an existing gem.
You can merge this PR yourself because you are a reviewer of this gem.
Just comment /merge to merge this PR.

You can also request a review from other reviewers if you want.


You changed non-gem files.

@pocke, please review and approve the changes.

Copy link
Contributor

@rhiroe rhiroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE

Copy link

github-actions bot commented Jun 3, 2025

Thanks for your review, @rhiroe!

This PR still needs approval from the administrators.
The admin should review this PR and merge it manually.
Please get approval from the reviewers.

@ksss
Copy link
Collaborator Author

ksss commented Jun 4, 2025

Thanks!

@ksss ksss merged commit 9d4adbc into ruby:main Jun 4, 2025
7 checks passed
@ksss ksss deleted the rubocop-on-rbs-v1.7.0 branch June 4, 2025 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants