Fix type of ActiveSupport::Messages::Metadata #909
Conversation
|
@richardboehme Thanks for your contribution! Please follow the instructions below for each change. Available commandsYou can use the following commands by commenting on this PR.
|
richardboehme
force-pushed
the
activesupport-metadata-fix
branch
from
d6ed681 to
03a1b4a
Compare
| module ActiveSupport | ||
| module Messages | ||
| module Metadata | ||
| def self.pick_expiry: (untyped expires_at, untyped expires_in) -> untyped |
There was a problem hiding this comment.
pick_expiry seems singleton private method.
Does your application require this method type?
There was a problem hiding this comment.
No it's just the only method left from the generated ones that still exists. Should we remove it?
There was a problem hiding this comment.
Yes, If there is no use case, I believe the best approach is to remove it.
Singleton private methods have very limited use and are likely only used internally in Rails or through monkey patching.
There was a problem hiding this comment.
I agree and removed the method signature, so this should be good to go.
This is now a module and no class anymore. Also most generated methods for it do not exist anymore.
richardboehme
force-pushed
the
activesupport-metadata-fix
branch
from
03a1b4a to
db9272e
Compare
|
Thanks for your review, @ksss! @richardboehme, @ksss This PR is ready to be merged. |
|
/merge |
This is now a module and no class anymore. Also most generated methods for it do not exist anymore.
Fixes #883