add body_published_at to pages table (#295)

* add body_published_at to pages table

As a website editor I would like to know when a page was last edited, and which pages have updates that have yet to be published

Solution
- add body_published_at column to the pages table.
- when a page is published, set the value of body_published_at.
- If a page has unpublished changes, disply this on the index with a icon.

* add color to 'not published text'

* update page factory for testing

* Bugfix for automatic caching when page is updated

- uses website#save with after_save_commit callback instead of
  `belongs_to :website, touch: :purged_at` so that purged_at is not
touched when caching is not automatic

Co-authored-by: Jonathan Greenberg <[email protected]>

Author: codyjamesbrooks

Diff for: app/controllers/staff/pages_controller.rb

@@ -39,7 +39,8 @@ def update
   def preview; end
 
   def publish
-    @page.update(published_body: @page.unpublished_body)
+    @page.update(published_body: @page.unpublished_body,
+                 body_published_at: Time.current)
     flash[:success] = "#{@page.name} Page was successfully published."
     redirect_to event_staff_pages_path(current_event)
   end

Diff for: app/models/page.rb

@@ -4,7 +4,8 @@ class Page < ApplicationRecord
     'home' => { },
   }
 
-  belongs_to :website, touch: :purged_at
+  belongs_to :website
+  after_save_commit :purge_website_cache
 
   scope :published, -> { where.not(published_body: nil).where(hide_page: false) }
   scope :in_footer, -> { published.where.not(footer_category: [nil, ""]) }
@@ -33,6 +34,16 @@ def self.promote(page)
   def self.from_template(key, attrs)
     new(TEMPLATES[key].merge(template: key, name: key.titleize, slug: key, **attrs))
   end
+
+  def unpublished_changes?
+    published_body != unpublished_body
+  end
+
+  private
+
+  def purge_website_cache
+    website.save
+  end
 end
 
 # == Schema Information

Diff for: app/models/website.rb

@@ -21,7 +21,6 @@ class Website < ApplicationRecord
   has_one_attached :background
   has_one_attached :favicon
 
-  after_touch :purge_cache, if: :caching_automatic?
   around_update :purge_cache, if: :caching_automatic?
 
   DEFAULT = 'default'.freeze
@@ -34,11 +33,9 @@ def manual_purge
     purge_cache { save }
   end
 
-  private
-
   def purge_cache
     self.purged_at = Time.current
-    yield if block_given?
+    yield
     FastlyService.service&.purge_by_key(event.slug)
   end
 end

Diff for: app/views/staff/pages/_page.html.haml

@@ -4,6 +4,14 @@
   %td
     - if page.published?
       %span.glyphicon.glyphicon-ok
+  %td
+    - if page.published?
+      = time_ago_in_words(page.body_published_at || page.updated_at)
+    - else
+      %span.label-warning Not Published
+  %td
+    - if page.unpublished_changes?
+      %span.glyphicon.glyphicon-bell
   %td
     - if page.landing?
       %span.glyphicon.glyphicon-ok

Diff for: app/views/staff/pages/index.html.haml

@@ -14,6 +14,8 @@
           %th Name
           %th Slug
           %th Published
+          %th Last Published
+          %th Unpublished Changes
           %th Landing Page
           %th
             Actions

Diff for: db/migrate/20220523185412_add_body_published_at_to_pages.rb

@@ -0,0 +1,5 @@
+class AddBodyPublishedAtToPages < ActiveRecord::Migration[6.1]
+  def change
+    add_column :pages, :body_published_at, :datetime, default: nil
+  end
+end

Diff for: db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 2022_05_12_134224) do
+ActiveRecord::Schema.define(version: 2022_05_23_185412) do
 
   # These are extensions that must be enabled in order to support this database
   enable_extension "plpgsql"
@@ -115,6 +115,7 @@
     t.boolean "hide_footer", default: false, null: false
     t.boolean "hide_page", default: false, null: false
     t.string "footer_category"
+    t.datetime "body_published_at"
     t.index ["website_id"], name: "index_pages_on_website_id"
   end
 

Diff for: spec/factories/pages.rb

@@ -5,5 +5,6 @@
     sequence(:slug) { |i| "home#{i if i > 1}" }
     unpublished_body { "<p>#{Faker::Lorem.paragraph}</p>" }
     published_body { "<p>#{Faker::Lorem.paragraph}</p>" }
+    body_published_at { DateTime.now - 1.day }
   end
 end