add created_at filter and orders to talks api (#645)

Author: adrienpoly

app/controllers/talks_controller.rb

@@ -18,8 +18,9 @@ def index
     @talks = @talks.for_event(params[:event]) if params[:event].present?
     @talks = @talks.for_speaker(params[:speaker]) if params[:speaker].present?
     @talks = @talks.where(kind: talk_kind) if talk_kind.present?
+    @talks = @talks.where("created_at >= ?", created_after) if created_after
     @talks = @talks.order(order_by) if order_by
-    @pagy, @talks = pagy(@talks, items: 20, page: params[:page]&.to_i || 1)
+    @pagy, @talks = pagy(@talks, **pagy_params)
   end
 
   # GET /talks/1
@@ -50,7 +51,9 @@ def order_by
     return if params[:s].present? && params[:order_by].blank?
     order_by_options = {
       "date_desc" => "talks.date DESC",
-      "date_asc" => "talks.date ASC"
+      "date_asc" => "talks.date ASC",
+      "created_at_desc" => "talks.created_at DESC",
+      "created_at_asc" => "talks.created_at ASC"
     }
 
     @order_by ||= begin
@@ -60,6 +63,19 @@ def order_by
     end
   end
 
+  def created_after
+    Date.parse(params[:created_after]) if params[:created_after].present?
+  rescue ArgumentError
+    nil
+  end
+
+  def pagy_params
+    {
+      limit: params[:limit]&.to_i,
+      page: params[:page]&.to_i
+    }.compact_blank
+  end
+
   def talk_kind
     @talk_kind ||= params[:kind].presence_in(Talk.kinds.keys)
   end

test/controllers/talks_controller_test.rb

@@ -122,11 +122,39 @@ class TalksControllerTest < ActionDispatch::IntegrationTest
     assert_equal talk.slug, json_response["talks"].first["slug"]
   end
 
+  test "should get index as JSON with a custom per_page" do
+    assert Talk.watchable.count > 2
+    get talks_url(format: :json, limit: 2)
+    assert_response :success
+
+    json_response = JSON.parse(response.body)
+
+    assert_equal 2, json_response["talks"].size
+  end
+
   test "should get show as JSON" do
     get talk_url(@talk, format: :json)
     assert_response :success
 
     json_response = JSON.parse(response.body)
     assert_equal @talk.slug, json_response["talk"]["slug"]
   end
+
+  test "should get index with created_after" do
+    talk = Talk.create!(title: "test", description: "test", date: "2023-01-01", created_at: "2023-01-01", video_provider: "youtube")
+    talk_2 = Talk.create!(title: "test 2", description: "test", date: "2025-01-01", created_at: "2025-01-01", video_provider: "youtube")
+
+    get talks_url(created_after: "2024-01-01")
+    assert_response :success
+    assert assigns(:talks).size.positive?
+    refute assigns(:talks).ids.include?(talk.id)
+    assert assigns(:talks).ids.include?(talk_2.id)
+    assert assigns(:talks).all? { |talk| talk.created_at >= Date.parse("2024-01-01") }
+  end
+
+  test "should get index with invalide created_after" do
+    get talks_url(created_after: "wrong-date")
+    assert_response :success
+    assert assigns(:talks).size.positive?
+  end
 end

test/fixtures/talks.yml

@@ -77,6 +77,15 @@ two:
   slug: talk-title-2
   kind: "talk"
   date: "2025-01-31"
+  video_provider: youtube
+
+three:
+  title: talk title 3
+  description: talk descritpion 3
+  slug: talk-title-3
+  kind: "talk"
+  date: "2025-01-31"
+  video_provider: youtube
 
 brightonruby_2024_one:
   title: Getting to Two Million Users as a One Woman Dev Team

test/jobs/recurring/youtube_video_statistics_job_test.rb

@@ -3,7 +3,7 @@
 class Recurring::YoutubeVideoStatisticsJobTest < ActiveJob::TestCase
   test "should update view_count and like_count for youtube talks" do
     VCR.use_cassette("recurring_youtube_statistics_job", match_requests_on: [:method]) do
-      talk = Talk.youtube.first
+      talk = talks(:one)
       assert_not talk.view_count.positive?
       assert_not talk.like_count.positive?
       Recurring::YoutubeVideoStatisticsJob.new.perform