Implement PartnerUpdateService for mandatory fields validation and update error handling

Author: Olexii Kasianenko

app/controllers/admin/partners_controller.rb

@@ -13,10 +13,11 @@ def edit
 
   def update
     @partner = Partner.find(params[:id])
-    if @partner.update(partner_attributes)
+    partner_update_service = PartnerUpdateService.new(@partner, partner_attributes)
+    if partner_update_service.call
       redirect_to admin_partners_path, notice: "#{@partner.name} updated!"
     else
-      flash.now[:error] = "Something didn't work quite right -- try again?"
+      flash.now[:error] = partner_update_service.error
       render action: :edit
     end
   end

app/services/partner_update_service.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+class PartnerUpdateService
+  attr_accessor :partner, :params, :error
+
+  def initialize(partner, params)
+    @partner = partner
+    @params = params
+  end
+
+  def call
+    return false unless validation
+
+    if partner.update(params)
+      true
+    else
+      @error = partner.errors.full_messages.join(", ")
+      false
+    end
+  end
+
+  private
+
+  def validation
+    mandatory_fields = %i[name]
+    missing_fields = mandatory_fields.select { |field| params[field].blank? }
+    if missing_fields.any?
+      @error = "Missing mandatory fields: #{missing_fields.join(', ')}"
+      return false
+    end
+    true
+  end
+end

spec/requests/partners/profiles_requests_spec.rb

@@ -100,11 +100,34 @@
     end
 
     context "with no social media" do
+      before do
+        partner.awaiting_review!
+      end
+      let(:params) do
+        {
+          partner: {
+            name: "Partnerdude", profile: {
+              no_social_media_presence: '0',
+              website: "",
+              twitter: "",
+              facebook: "",
+              instagram: "",
+              agency_type: 'OTHER',
+              address1: '123 Main St',
+              city: 'Anytown',
+              state: 'CA',
+              zip_code: '12345',
+              program_name: 'Test Program',
+              program_description: 'Test Description'
+            }
+          }
+        }
+      end
+
       it "shows an error" do
-        put partners_profile_path(partner,
-          partner: {name: "Partnerdude", profile: {no_social_media_presence: false}})
+        put partners_profile_path(partner, params)
         expect(response).not_to redirect_to(anything)
-        expect(response.body).to include("No social media presence must be checked if you have not provided any of Website, Twitter, Facebook, or Instagram.")
+        expect(response.body).to include("At least one social media field must be filled out or 'No social media presence' must be checked")
       end
     end
 

spec/system/partner_system_spec.rb

@@ -522,12 +522,10 @@
 
           # Expect an alert-danger message containing validation errors
           expect(page).to have_css(".alert-danger", text: /There is a problem/)
-          expect(page).to have_content("No social media presence must be checked if you have not provided any of Website, Twitter, Facebook, or Instagram.")
           expect(page).to have_content("Enable child based requests At least one request type must be set")
           expect(page).to have_content("Pick up email can't have more than three email addresses")
 
           # Expect media section, pick up person section, and partner settings section to be opened
-          expect(page).to have_css("#media_information.accordion-collapse.collapse.show", visible: true)
           expect(page).to have_css("#pick_up_person.accordion-collapse.collapse.show", visible: true)
           expect(page).to have_css("#partner_settings.accordion-collapse.collapse.show", visible: true)
 
@@ -536,12 +534,10 @@
 
           # Expect an alert-danger message containing validation errors
           expect(page).to have_css(".alert-danger", text: /There is a problem/)
-          expect(page).to have_content("No social media presence must be checked if you have not provided any of Website, Twitter, Facebook, or Instagram.")
           expect(page).to have_content("Enable child based requests At least one request type must be set")
           expect(page).to have_content("Pick up email can't have more than three email addresses")
 
           # Expect media section, pick up person section, and partner settings section to be opened
-          expect(page).to have_css("#media_information.accordion-collapse.collapse.show", visible: true)
           expect(page).to have_css("#pick_up_person.accordion-collapse.collapse.show", visible: true)
           expect(page).to have_css("#partner_settings.accordion-collapse.collapse.show", visible: true)
         end

spec/system/partners/profile_edit_system_spec.rb

@@ -346,7 +346,7 @@
               subject
             }.not_to change { partner1.reload.updated_at }
 
-            expect(page).to have_content("No social media presence must be checked if you have not provided any of Website, Twitter, Facebook, or Instagram.")
+            expect(page).to have_content("At least one social media field must be filled out or 'No social media presence' must be checked.")
           end
         end
 
@@ -360,7 +360,7 @@
               subject
             }.not_to change { partner1.reload.updated_at }
 
-            expect(page).to have_content("No social media presence must be checked if you have not provided any of Website, Twitter, Facebook, or Instagram.")
+            expect(page).to have_content("At least one social media field must be filled out or 'No social media presence' must be checked.")
           end
 
           context "partner's organization one_step_partner_invite is true" do
@@ -419,7 +419,7 @@
             expect {
               subject
             }.not_to change { partner1.reload.updated_at }
-            expect(page).to have_content("Missing mandatory fields: agency_type, address1, city, state, zip_code, program_name, program_description, agency_name")
+            expect(page).to have_content("Missing mandatory fields: agency_name, agency_type, address1, city, state, zip_code, program_name, program_description")
           end
         end
 
@@ -432,7 +432,7 @@
             expect {
               subject
             }.not_to change { partner1.reload.updated_at }
-            expect(page).to have_content("Missing mandatory fields: agency_type, address1, city, state, zip_code, program_name, program_description, agency_name")
+            expect(page).to have_content("Missing mandatory fields: agency_name, agency_type, address1, city, state, zip_code, program_name, program_description")
           end
 
           context "partner's organization one_step_partner_invite is true" do