Skip to content

Contribution Guidelines

DavidMikeSimon edited this page Dec 19, 2011 · 40 revisions

From the Rubinius contribution page:

Writing code and participating should be fun, not an exercise in perseverance. Stringent commit polices, for whatever their other qualities may bring, also mean longer turnaround times.

Submit a patch and once it’s accepted, you’ll get commit access to the repository. Feel free to fork the repository and send a pull request, once it’s merged in you’ll get added. If not, feel free to bug qrush about it.

Also, if you’re hacking on Gemcutter, hop in #rubygems on irc.freenode.net! Chances are someone else will be around to answer questions or bounce ideas off of.

How To Contribute

  • Clone: git clone git://github.com/rubygems/rubygems.org.git
  • Get Setup
  • Create a topic branch: git checkout -b awesome_feature
  • Commit away.
  • Keep up to date: git fetch && git rebase origin/master.

Once you’re ready:

  • Fork the project on GitHub
  • Add your repository as a remote: git remote add your_remote your_repo
  • Push up your branch: git push your_remote awesome_feature
  • Create a Pull Request for the topic branch, asking for review.

Once it’s accepted:

  • If you want access to the core repository feel free to ask! Then you can change origin to point to the Read+Write URL:
    git remote set-url origin [email protected]:rubygems/rubygems.org.git
    Otherwise, you can continue to hack away in your own fork.

If you’re looking for things to hack on, please check GitHub Issues. If you’ve found bugs or have feature ideas don’t be afraid to pipe up and ask the mailing list or IRC channel (#gemcutter on irc.freenode.net) about them.

Acceptance

Contributions WILL NOT be accepted without tests. If it’s a brand new feature, you should have a Cucumber scenario (or several!) as well. If you haven’t tested before, start reading up in the test/ directory to see what’s going on. If you’ve got good links regarding TDD or testing in general feel free to add them here!

Branching

For your own development, use the topic branches. Basically, cut each feature into its own branch and send pull requests based off those.

On the main repo, branches are used as follows:

Branch Used for…
master The main development branch. Always should be fast-forwardable.
staging Whatever’s currently on http://staging.rubygems.org. Can be moved around as needed to test out new features/fixes. If you want to test out your changes on our staging server, bug qrush and you can play around there.
production What’s currently on http://gemcutter.org. Should be updated when deploys happen from master with git push origin master:production
Topic branches Individual features/fixes. These should be moved around/rebased on top of the latest master before submitting. Makes your patches easier to merge and keep the history clean if at all possible.
Clone this wiki locally