Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

CMD + Click on a definition should show the best match first #857

Open
davidalejandroaguilar opened this issue Mar 31, 2023 · 1 comment
Labels

Comments

@davidalejandroaguilar
Copy link

davidalejandroaguilar commented Mar 31, 2023

Your environment

  • vscode-ruby version: 0.28.1
  • Ruby version: 3.1.2
  • Ruby version manager (if any): asdf
  • VS Code version: 1.76.2
  • Operating System: Mac OS Monterrey 12.6
  • Using language server? (eg useLanguageServer is true in your configuration?) Yes (rubyLocate)

Expected behavior

CMD + Click on a definition should either:

  • Show the best match first.
  • Show the best match outside the suggestions panel for a quick click.

Solargraph

Solargraph does the right thing, but unfortunately, clicking it takes you to the literal definition, not to the actual code.

Example:

Screen.Recording.2023-03-31.at.1.46.01.a.m.mov

Actual behavior

CMD + Click on User::CreateOperation shows 3 definitions on the Intellisense pane.

For example:

  • Admin::CreateOperation
  • Employee::CreateOperation (this one shown on the details pane)
  • User::CreateOperation

Real example:

Screen.Recording.2023-03-31.at.1.17.58.a.m.mov

I then have to search this pane for User::CreateOperation instead of it being at the top.


Not familiar with the codebase but let me know how I can help.

@davidalejandroaguilar davidalejandroaguilar changed the title CMD + Click on a namespaced constant should show the best match first CMD + Click on a definition should show the best match first Mar 31, 2023
@github-actions
Copy link

This issue has not had activity for 30 days. It will be automatically closed in 30 days.

@github-actions github-actions bot added the stale label Jul 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant