Clippy fixes

Signed-off-by: Samuel Giddins <[email protected]>

Author: segiddins

src/platform.rs

@@ -36,7 +36,7 @@ impl Platform<'_> {
       parts.pop_back();
     }
 
-    if parts.len() > 2 && !DOTTED_PATTERN.is_match(&parts.back().unwrap()) {
+    if parts.len() > 2 && !DOTTED_PATTERN.is_match(parts.back().unwrap()) {
       let extra = parts.pop_back().unwrap();
       let last = parts.pop_back().unwrap();
       let e = last.as_ptr();
@@ -51,7 +51,7 @@ impl Platform<'_> {
         if cpu.is_empty() {
           panic!("empty cpu in platform {:?}", s);
         }
-        if I86_PATTERN.is_match(&cpu) {
+        if I86_PATTERN.is_match(cpu) {
           Some("x86")
         } else {
           Some(cpu)
@@ -60,7 +60,7 @@ impl Platform<'_> {
       None => panic!("empty cpu in platform {:?}", s),
     };
 
-    if parts.len() == 2 && DOTTED_PATTERN.is_match(&parts[1]) {
+    if parts.len() == 2 && DOTTED_PATTERN.is_match(parts[1]) {
       return Platform {
         cpu,
         os: parts.pop_front().unwrap(),
@@ -121,7 +121,7 @@ impl Platform<'_> {
 
     let mut double_locs = MSWIN_PATTERN.capture_locations();
 
-    if MSWIN_PATTERN.captures_read(&mut double_locs, &os).is_some() {
+    if MSWIN_PATTERN.captures_read(&mut double_locs, os).is_some() {
       version = capture(&double_locs, os, 2);
       os = capture(&double_locs, os, 1).unwrap();
       if cpu.is_none() && os.ends_with("32") {
@@ -137,16 +137,13 @@ impl Platform<'_> {
 
     os = "unknown";
 
-    return Platform { cpu, os, version };
+    Platform { cpu, os, version }
   }
 }
 
 impl std::fmt::Display for Platform<'_> {
   fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
-    match (&self.cpu, &self.os, &self.version) {
-      (None, os, Some(version)) => return write!(f, "{}{}", os, version),
-      _ => (),
-    }
+    if let (None, os, Some(version)) = (&self.cpu, &self.os, &self.version) { return write!(f, "{}{}", os, version) }
     if let Some(cpu) = self.cpu {
       write!(f, "{}-", cpu)?;
     }

src/user_agent.rs

@@ -1,5 +1,3 @@
-use std::borrow::Cow;
-
 use crate::platform::Platform;
 use regex::Regex;
 
@@ -120,7 +118,7 @@ pub fn parse(a: &str) -> Option<UserAgent> {
   }
 }
 
-pub fn serialize_user_agent<S>(ua: &Cow<str>, serializer: S) -> Result<S::Ok, S::Error>
+pub fn serialize_user_agent<S>(ua: &str, serializer: S) -> Result<S::Ok, S::Error>
 where
   S: serde::Serializer,
 {