Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PSR LoggerInterface instead of Ruckusing_Util_Logger. #183

Open
herregroen opened this issue Oct 3, 2018 · 0 comments
Open

Use PSR LoggerInterface instead of Ruckusing_Util_Logger. #183

herregroen opened this issue Oct 3, 2018 · 0 comments

Comments

@herregroen
Copy link

herregroen commented Oct 3, 2018

The Ruckusing_Util_Logger is not PSR compatible ( see https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-3-logger-interface.md ). It's log method should accept a log level as the first argument and the message as the second argument.

Because the Ruckusing_Util_Logger is not PSR compatible it's impossible to reuse existing loggers that will in all likelihood be compatible with that standard.

All methods that accept a Ruckusing_Util_Logger should also be typehinted with LoggerInterface instead so that projects may more easily reuse existing loggers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant