Skip to content

Commit 87fce5c

Browse files
committed
fix: Use only local unitxt catalogs when in offline mode (trustyai-explainability#386)
(cherry picked from commit 8a5a958)
1 parent a08389c commit 87fce5c

File tree

2 files changed

+52
-0
lines changed

2 files changed

+52
-0
lines changed

controllers/lmes/lmevaljob_controller.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -787,6 +787,10 @@ func CreatePod(svcOpts *serviceOptions, job *lmesv1alpha1.LMEvalJob, log logr.Lo
787787
Name: "HF_EVALUATE_OFFLINE",
788788
Value: "1",
789789
},
790+
{
791+
Name: "UNITXT_USE_ONLY_LOCAL_CATALOGS",
792+
Value: "True",
793+
},
790794
}
791795

792796
// Enforce offline mode by default

controllers/lmes/lmevaljob_controller_test.go

Lines changed: 48 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,10 @@ func Test_SimplePod(t *testing.T) {
153153
Name: "HF_EVALUATE_OFFLINE",
154154
Value: "1",
155155
},
156+
{
157+
Name: "UNITXT_USE_ONLY_LOCAL_CATALOGS",
158+
Value: "True",
159+
},
156160
},
157161
},
158162
},
@@ -373,6 +377,10 @@ func Test_WithCustomPod(t *testing.T) {
373377
Name: "HF_EVALUATE_OFFLINE",
374378
Value: "1",
375379
},
380+
{
381+
Name: "UNITXT_USE_ONLY_LOCAL_CATALOGS",
382+
Value: "True",
383+
},
376384
},
377385
},
378386
{
@@ -575,6 +583,10 @@ func Test_EnvSecretsPod(t *testing.T) {
575583
Name: "HF_EVALUATE_OFFLINE",
576584
Value: "1",
577585
},
586+
{
587+
Name: "UNITXT_USE_ONLY_LOCAL_CATALOGS",
588+
Value: "True",
589+
},
578590
},
579591
Command: generateCmd(svcOpts, job),
580592
Args: generateArgs(svcOpts, job, log),
@@ -741,6 +753,10 @@ func Test_FileSecretsPod(t *testing.T) {
741753
Name: "HF_EVALUATE_OFFLINE",
742754
Value: "1",
743755
},
756+
{
757+
Name: "UNITXT_USE_ONLY_LOCAL_CATALOGS",
758+
Value: "True",
759+
},
744760
},
745761
VolumeMounts: []corev1.VolumeMount{
746762
{
@@ -1206,6 +1222,10 @@ func Test_ManagedPVC(t *testing.T) {
12061222
Name: "HF_EVALUATE_OFFLINE",
12071223
Value: "1",
12081224
},
1225+
{
1226+
Name: "UNITXT_USE_ONLY_LOCAL_CATALOGS",
1227+
Value: "True",
1228+
},
12091229
},
12101230

12111231
VolumeMounts: []corev1.VolumeMount{
@@ -1361,6 +1381,10 @@ func Test_ExistingPVC(t *testing.T) {
13611381
Name: "HF_EVALUATE_OFFLINE",
13621382
Value: "1",
13631383
},
1384+
{
1385+
Name: "UNITXT_USE_ONLY_LOCAL_CATALOGS",
1386+
Value: "True",
1387+
},
13641388
},
13651389
VolumeMounts: []corev1.VolumeMount{
13661390
{
@@ -1533,6 +1557,10 @@ func Test_PVCPreference(t *testing.T) {
15331557
Name: "HF_EVALUATE_OFFLINE",
15341558
Value: "1",
15351559
},
1560+
{
1561+
Name: "UNITXT_USE_ONLY_LOCAL_CATALOGS",
1562+
Value: "True",
1563+
},
15361564
},
15371565
VolumeMounts: []corev1.VolumeMount{
15381566
{
@@ -1736,6 +1764,10 @@ func Test_OfflineMode(t *testing.T) {
17361764
Name: "HF_EVALUATE_OFFLINE",
17371765
Value: "1",
17381766
},
1767+
{
1768+
Name: "UNITXT_USE_ONLY_LOCAL_CATALOGS",
1769+
Value: "True",
1770+
},
17391771
},
17401772
VolumeMounts: []corev1.VolumeMount{
17411773
{
@@ -1940,6 +1972,10 @@ func Test_ProtectedVars(t *testing.T) {
19401972
Name: "HF_EVALUATE_OFFLINE",
19411973
Value: "1",
19421974
},
1975+
{
1976+
Name: "UNITXT_USE_ONLY_LOCAL_CATALOGS",
1977+
Value: "True",
1978+
},
19431979
},
19441980
VolumeMounts: []corev1.VolumeMount{
19451981
{
@@ -2123,6 +2159,10 @@ func Test_OnlineModeDisabled(t *testing.T) {
21232159
Name: "HF_EVALUATE_OFFLINE",
21242160
Value: "1",
21252161
},
2162+
{
2163+
Name: "UNITXT_USE_ONLY_LOCAL_CATALOGS",
2164+
Value: "True",
2165+
},
21262166
},
21272167
VolumeMounts: []corev1.VolumeMount{
21282168
{
@@ -2632,6 +2672,10 @@ func Test_AllowCodeOfflineMode(t *testing.T) {
26322672
Name: "HF_EVALUATE_OFFLINE",
26332673
Value: "1",
26342674
},
2675+
{
2676+
Name: "UNITXT_USE_ONLY_LOCAL_CATALOGS",
2677+
Value: "True",
2678+
},
26352679
},
26362680
VolumeMounts: []corev1.VolumeMount{
26372681
{
@@ -2812,6 +2856,10 @@ func Test_OfflineModeWithOutput(t *testing.T) {
28122856
Name: "HF_EVALUATE_OFFLINE",
28132857
Value: "1",
28142858
},
2859+
{
2860+
Name: "UNITXT_USE_ONLY_LOCAL_CATALOGS",
2861+
Value: "True",
2862+
},
28152863
},
28162864
VolumeMounts: []corev1.VolumeMount{
28172865
{

0 commit comments

Comments
 (0)