Skip to content

Commit aef1187

Browse files
authored
Merge pull request #211 from runpod-workers/fix/allow-none-as-string
fix: allow "None" as value & parse the value of RAW_OPENAI_OUTPUT correctly
2 parents f7514de + 121a3dd commit aef1187

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

src/engine.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,12 @@ def __init__(self, vllm_engine):
178178
self.response_role = os.getenv("OPENAI_RESPONSE_ROLE") or "assistant"
179179
self.lora_adapters = self._load_lora_adapters()
180180
asyncio.run(self._initialize_engines())
181-
self.raw_openai_output = bool(int(os.getenv("RAW_OPENAI_OUTPUT", 1)))
181+
# Handle both integer and boolean string values for RAW_OPENAI_OUTPUT
182+
raw_output_env = os.getenv("RAW_OPENAI_OUTPUT", "1")
183+
if raw_output_env.lower() in ('true', 'false'):
184+
self.raw_openai_output = raw_output_env.lower() == 'true'
185+
else:
186+
self.raw_openai_output = bool(int(raw_output_env))
182187

183188
def _load_lora_adapters(self):
184189
adapters = []

src/engine_args.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ def match_vllm_args(args):
111111
"""
112112
renamed_args = {RENAME_ARGS_MAP.get(k, k): v for k, v in args.items()}
113113
matched_args = {k: v for k, v in renamed_args.items() if k in AsyncEngineArgs.__dataclass_fields__}
114-
return {k: v for k, v in matched_args.items() if v not in [None, ""]}
114+
return {k: v for k, v in matched_args.items() if v not in [None, "", "None"]}
115115
def get_local_args():
116116
"""
117117
Retrieve local arguments from a JSON file.

0 commit comments

Comments
 (0)