Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[runwhen-local-feedback] need to log error but continue rendering on codebundle resolution issues #332

Open
stewartshea opened this issue Sep 19, 2023 · 0 comments
Assignees

Comments

@stewartshea
Copy link
Contributor

Observation
When we encounter a template error, the cheat sheet rendering fails hard.

Here is an example of the logs in such a situation:

WARNING -  [00:57:16] "GET /runwhen-local/runwhen-local-Namespace-Health/ HTTP/1.1" code 404
WARNING -  [00:57:46] "GET /runwhen-local/runwhen-local-Namespace-Health/ HTTP/1.1" code 404
Traceback (most recent call last):
  File "/workspace-builder/run.py", line 497, in <module>
    main()
  File "/workspace-builder/run.py", line 410, in main
    cheatsheet.cheat_sheet(output_path)
  File "/workspace-builder/cheatsheet.py", line 699, in cheat_sheet
    parsed_robot = parse_robot_file(robot_file)
  File "/workspace-builder/cheatsheet.py", line 35, in parse_robot_file
    suite = TestSuite.from_file_system(fpath)
  File "/opt/pysetup/.venv/lib/python3.9/site-packages/robot/running/model.py", line 294, in from_file_system
    return TestSuiteBuilder(**config).build(*paths)
  File "/opt/pysetup/.venv/lib/python3.9/site-packages/robot/running/builder/builders.py", line 87, in build
    structure = SuiteStructureBuilder(self.included_extensions,
  File "/opt/pysetup/.venv/lib/python3.9/site-packages/robot/parsing/suitestructure.py", line 58, in build
    paths = list(self._normalize_paths(paths))
  File "/opt/pysetup/.venv/lib/python3.9/site-packages/robot/parsing/suitestructure.py", line 70, in _normalize_paths
    raise DataError("Parsing '%s' failed: File or directory to "
robot.errors.DataError: Parsing '/workspace-builder/rw-public-codecollection-cache/codebundles/curl-gmp-kong-ingress-inspection/runbook.robot' failed: File or directory to execute does not exist.
WARNING -  [00:58:16] "GET /runwhen-local/runwhen-local-Namespace-Health/ HTTP/1.1" code 404
WARNING -  [00:58:46] "GET /runwhen-local/runwhen-local-Namespace-Health/ HTTP/1.1" code 404
WARNING -  [00:59:16] "GET /runwhen-local/runwhen-local-Namespace-Health/ HTTP/1.1" code 404

Possible Suggestions
Print the errors in the logs but continue processing the rules - a simple validation check should help this scenario.

Any other details or context

@stewartshea stewartshea self-assigned this Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant