Merge #517: Fix a few missed cases of "vXY and later only" in types

c803543 Remove deprecated field from getpeerinfo (Jamil Lambert, PhD)
8202a20 Tidy up docs (Jamil Lambert, PhD)

Pull request description:

  #513 missed a few cases of "vXY and later only" comments that had different wording and didn't come up in the grep. Do a more general search and fix what is found.

  One of the fields in types for `PeerInfo` was marked as "(deprecated in v0.21)" and set as an option in v22 and v26. The field is not in the RPC docs for either v22 or v26 and the tests pass with it being removed.

  - Remove the deprecated `whitelisted` field from `PeerInfo`.
  - Tidy up the docs.

ACKs for top commit:
  tcharding:
    ACK c803543

Tree-SHA512: 2c7c9ab2ff42dc42718d8128bf555baddc2ab9dd1f13fa1d9001108393c9f564252e1a781edab66696d3aebdfd3a9f1bd7278914b009b73e441114e4bf1783e3

Author: tcharding

types/src/v17/wallet/mod.rs

@@ -251,8 +251,6 @@ pub struct GetAddressInfo {
     #[serde(rename = "hdseedid")]
     pub hd_seed_id: Option<String>,
     /// Alias for hdseedid maintained for backwards compatibility.
-    ///
-    /// Will be removed in V0.18.
     #[serde(rename = "hdmasterkeyid")]
     pub hd_master_key_id: Option<String>,
     /// Array of labels associated with the address.

types/src/v20/wallet/mod.rs

@@ -209,7 +209,7 @@ pub struct GetTransaction {
     /// The time received in seconds since epoch (1 Jan 1970 GMT).
     #[serde(rename = "timereceived")]
     pub time_received: u32,
-    /// If a comment is associated with the transaction, only present if not empty. v20 to v24 only.
+    /// If a comment is associated with the transaction, only present if not empty.
     pub comment: Option<String>,
     /// Whether this transaction could be replaced due to BIP125 (replace-by-fee);
     /// may be unknown for unconfirmed transactions not in the mempool

types/src/v22/network.rs

@@ -131,8 +131,6 @@ pub struct PeerInfo {
     pub addresses_rate_limited: usize,
     /// Any special permissions that have been granted to this peer.
     pub permissions: Vec<String>,
-    /// Whether the peer is whitelisted.
-    pub whitelisted: Option<bool>,
     /// The minimum fee rate for transactions this peer accepts.
     #[serde(rename = "minfeefilter")]
     pub min_fee_filter: Option<f64>, // Docs rekon this exists.

types/src/v26/blockchain/into.rs

@@ -11,7 +11,7 @@ use crate::model;
 use crate::v25::ScanBlocksStartError;
 
 impl GetChainStates {
-    /// Converts v26 GetChainStates (and its ChainState subtypes) to model::GetChainStates
+    /// Converts version specific type to a version nonspecific, more strongly typed type.
     pub fn into_model(self) -> Result<model::GetChainStates, GetChainStatesError> {
         use GetChainStatesError as E;
 

types/src/v26/network.rs

@@ -139,8 +139,6 @@ pub struct PeerInfo {
     /// The minimum fee rate for transactions this peer accepts.
     #[serde(rename = "minfeefilter")]
     pub minimum_fee_filter: f64,
-    /// Whether the peer is whitelisted (deprecated in v0.21).
-    pub whitelisted: Option<bool>,
     /// The total bytes sent aggregated by message type.
     #[serde(rename = "bytessent_per_msg")]
     pub bytes_sent_per_message: BTreeMap<String, u64>,

types/src/v26/wallet/mod.rs

@@ -114,7 +114,7 @@ pub struct GetTransaction {
     /// The time received in seconds since epoch (1 Jan 1970 GMT).
     #[serde(rename = "timereceived")]
     pub time_received: u32,
-    /// If a comment is associated with the transaction, only present if not empty. v20 to v24 only.
+    /// If a comment is associated with the transaction, only present if not empty.
     pub comment: Option<String>,
     /// Whether this transaction could be replaced due to BIP125 (replace-by-fee);
     /// may be unknown for unconfirmed transactions not in the mempool

types/src/v28/network.rs

@@ -55,7 +55,7 @@ pub struct GetNetworkInfo {
     /// List of local addresses.
     #[serde(rename = "localaddresses")]
     pub local_addresses: Vec<GetNetworkInfoAddress>,
-    /// Any network and blockchain warnings. Before v28 this was a single String.
+    /// Any network and blockchain warnings.
     pub warnings: Vec<String>,
 }
 

types/src/v29/blockchain/into.rs

@@ -355,7 +355,7 @@ impl GetBlockHeaderVerbose {
 }
 
 impl GetChainStates {
-    /// Converts v26 GetChainStates (and its ChainState subtypes) to model::GetChainStates
+    /// Converts version specific type to a version nonspecific, more strongly typed type.
     pub fn into_model(self) -> Result<model::GetChainStates, GetChainStatesError> {
         use GetChainStatesError as E;
 

types/src/v29/blockchain/mod.rs

@@ -364,7 +364,7 @@ pub struct GetBlockHeaderVerbose {
     pub nonce: i64,
     /// The bits.
     pub bits: String,
-    /// The difficulty target (hex-encoded). From v29+.
+    /// The difficulty target (hex-encoded).
     pub target: String,
     /// The difficulty.
     pub difficulty: f64,

types/src/v29/hidden/mod.rs

@@ -34,22 +34,20 @@ pub struct GetOrphanTxsVerboseOne(pub Vec<GetOrphanTxsVerboseOneEntry>);
 #[derive(Clone, Debug, PartialEq, Deserialize, Serialize)]
 #[cfg_attr(feature = "serde-deny-unknown-fields", serde(deny_unknown_fields))]
 pub struct GetOrphanTxsVerboseOneEntry {
-    /// The transaction hash in hex
+    /// The transaction hash in hex.
     pub txid: String,
-    /// The transaction witness hash in hex
+    /// The transaction witness hash in hex.
     pub wtxid: String,
-    /// The serialized transaction size in bytes
+    /// The serialized transaction size in bytes.
     pub bytes: u64,
     /// The virtual transaction size as defined in BIP 141. This is different from actual serialized size for witness transactions as witness data is discounted.
     pub vsize: u64,
     /// The transaction weight as defined in BIP 141.
     pub weight: u64,
-    /// The entry time into the orphanage expressed in UNIX epoch time
-    /// Only present in v29.
+    /// The entry time into the orphanage expressed in UNIX epoch time.
     #[serde(rename = "entry")]
     pub entry_time: u32,
-    /// The orphan expiration time expressed in UNIX epoch time
-    /// Only present in v29.
+    /// The orphan expiration time expressed in UNIX epoch time.
     #[serde(rename = "expiration")]
     pub expiration_time: u32,
     /// List of peer ids that we store this transaction for.
@@ -68,24 +66,23 @@ pub struct GetOrphanTxsVerboseTwo(pub Vec<GetOrphanTxsVerboseTwoEntry>);
 #[derive(Clone, Debug, PartialEq, Deserialize, Serialize)]
 #[cfg_attr(feature = "serde-deny-unknown-fields", serde(deny_unknown_fields))]
 pub struct GetOrphanTxsVerboseTwoEntry {
-    /// The transaction hash in hex
+    /// The transaction hash in hex.
     pub txid: String,
-    /// The transaction witness hash in hex
+    /// The transaction witness hash in hex.
     pub wtxid: String,
-    /// The serialized transaction size in bytes
+    /// The serialized transaction size in bytes.
     pub bytes: u64,
-    /// The virtual transaction size as defined in BIP 141. This is different from actual serialized size for witness transactions as witness data is discounted.
+    /// The virtual transaction size as defined in BIP 141. This is different from actual serialized
+    /// size for witness transactions as witness data is discounted.
     pub vsize: u64,
     /// The transaction weight as defined in BIP 141.
     pub weight: u64,
     /// List of peer ids that we store this transaction for.
     pub from: Vec<u64>,
-    /// The entry time into the orphanage expressed in UNIX epoch time
-    /// Only present in v29.
+    /// The entry time into the orphanage expressed in UNIX epoch time.
     #[serde(rename = "entry")]
     pub entry_time: u32,
-    /// The orphan expiration time expressed in UNIX epoch time
-    /// Only present in v29.
+    /// The orphan expiration time expressed in UNIX epoch time.
     #[serde(rename = "expiration")]
     pub expiration_time: u32,
     /// The serialized, hex-encoded transaction data.