Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not post a comment for unrelated errors #124

Open
Kobzol opened this issue Aug 14, 2024 · 0 comments
Open

Do not post a comment for unrelated errors #124

Kobzol opened this issue Aug 14, 2024 · 0 comments

Comments

@Kobzol
Copy link
Contributor

Kobzol commented Aug 14, 2024

After every comment on a PR, the bot tries to load the PR information from GitHub. However, this can fail, and in that case the bot starts spamming the PR with error messages. The bot should post a comment when it encounters an error during its operation, but not when it just deals with a comment that is completely unrelated to it. We should first find out whether the comment actually contains a bors command, and if not, we should just always ignore it.

I originally included the PR info loading logic unconditionally to reduce code duplication (so that we always load the PR regardless of the event), but it was a bad idea. We are also needlessly spamming GitHub now, even though most comments are unrelated to bors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant