Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signal types missing for some embedded targets #3615

Open
madsmtm opened this issue Mar 7, 2024 · 4 comments
Open

Signal types missing for some embedded targets #3615

madsmtm opened this issue Mar 7, 2024 · 4 comments
Labels
C-API-request Category: API request E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Milestone

Comments

@madsmtm
Copy link
Contributor

madsmtm commented Mar 7, 2024

I'm just getting started with embedded programming, and found that compiling the standard library using rust-analyzer with -Zbuild-std fails because of this line.

I'm not entirely sure, but it seems like this is entirely valid code, and that the problem lies with libc missing definitions for SIGABRT (and other signal handler #defines).

As far as I can tell, these are defined in newlib's sys/signal.h header, so perhaps the solution could be as simple as adding these to libc's newlib module? I can put up a PR if you think that's the way to go?

My target triple is riscv32imc-esp-espidf.

This would resolve the following issues:
esp-rs/esp-idf-svc#366
rust-lang/rust-analyzer#16552

@madsmtm madsmtm added the C-API-request Category: API request label Mar 7, 2024
@devnexen
Copy link
Contributor

I would suggest to go for the PR :)

@Tevz-Beskovnik
Copy link
Contributor

Hello, are you still planning on PRing this into libc? Otherwise I want to take a crack at it

@madsmtm
Copy link
Contributor Author

madsmtm commented Apr 14, 2024

I'm fine with you doing it, thanks!

@Vollbrecht
Copy link

Vollbrecht commented Apr 21, 2024

you initially linked cygwin-newlib implementation. Please keep in mind that esp's uses its own fork of newlib. So if you want to cross reference what is there and what not have a look here . If i understand correctly it should cover both newlib functions found in esp rom and the once that get compiled into the binary (for functions not present in the ROM).

@tgross35 tgross35 added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. and removed help wanted labels Aug 29, 2024
@tgross35 tgross35 added this to the 1.x milestone Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-API-request Category: API request E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

No branches or pull requests

5 participants