Inline assist on `.into()` produces wrong code

[pacak]

struct Foo {
    x: u32,
}

impl From<u32> for Foo {
    fn from(x: u32) -> Self {
        Foo { x }
    }
}

fn make(x: u32) -> Foo {
    x.into()
}

Consider this example. Attempting to use "inline assist" in into() result in this:

fn make(x: u32) -> Foo {
      U::from(x)
  }

While technically correct - it's not helpful. I'd expect to see Foo instead of U.

rust-analyzer version: rust-analyzer 1.93.0 (254b596 2026-01-19)

rustc version: rustc 1.93.0 (254b59607 2026-01-19)

editor or extension: neovim, rustaceanvim

relevant settings: Nothing really

repository link (if public, optional): (eg. rust-analyzer)

[eduardorittner]

AFAICT the code assist you should be using in this case is the "Convert into to fully qualified from" action, which correctly handles this case. The assist you're using is a generalized inline function assist which simply replaces the function call with its body, without resolving types.

[pacak]

Yeah, that action works and produces the right code. I'm more worried about this action producing code that can't possibly work since U doesn't exist in the best case scenario and exists and is wrong in the worst. How useful such inlines are?

[ChayimFriedman2]

This is indeed a bug.