Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: error[E0277]: the trait bound Box<dyn OptValueParse<'_>>: From<&mut [char]> is not satisfied #134710

Open
cuviper opened this issue Dec 23, 2024 · 3 comments
Labels
C-bug Category: This is a bug. I-prioritize Issue: Indicates that prioritization has been requested for this issue. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Milestone

Comments

@cuviper
Copy link
Member

cuviper commented Dec 23, 2024

[INFO] [stdout] error[E0277]: the trait bound `Box<dyn OptValueParse<'_>>: From<&mut [char]>` is not satisfied
[INFO] [stdout]    --> src/ovp.rs:513:23
[INFO] [stdout]     |
[INFO] [stdout] 513 |         OptValue::new(Box::from(self))
[INFO] [stdout]     |                       ^^^ the trait `From<&mut [char]>` is not implemented for `Box<dyn OptValueParse<'_>>`
[INFO] [stdout]     |
[INFO] [stdout]     = help: the following other types implement trait `From<T>`:
[INFO] [stdout]               `Box<CStr>` implements `From<&CStr>`
[INFO] [stdout]               `Box<CStr>` implements `From<&mut CStr>`
[INFO] [stdout]               `Box<CStr>` implements `From<CString>`
[INFO] [stdout]               `Box<CStr>` implements `From<Cow<'_, CStr>>`
[INFO] [stdout]               `Box<OsStr>` implements `From<&OsStr>`
[INFO] [stdout]               `Box<OsStr>` implements `From<&mut OsStr>`
[INFO] [stdout]               `Box<OsStr>` implements `From<Cow<'_, OsStr>>`
[INFO] [stdout]               `Box<OsStr>` implements `From<OsString>`
[INFO] [stdout]             and 23 others

... and many more errors with different From<_> types.

Version it worked on

It most recently worked on: 1.83.0

Version with regression

Using rustc 1.84.0-beta.4 in crater #134138.

@rustbot modify labels: +regression-from-stable-to-beta -regression-untriaged

@cuviper cuviper added C-bug Category: This is a bug. regression-untriaged Untriaged performance or correctness regression. labels Dec 23, 2024
@rustbot rustbot added I-prioritize Issue: Indicates that prioritization has been requested for this issue. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. regression-from-stable-to-beta Performance or correctness regression from stable to beta. and removed regression-untriaged Untriaged performance or correctness regression. labels Dec 23, 2024
@compiler-errors
Copy link
Member

I bisected this to the rollup: 7028d93 / #132555.

I'm suspicious about this PR: #129329

@compiler-errors
Copy link
Member

compiler-errors commented Dec 23, 2024

Funny enough, the implementation was changed after the crater run was performed (#129329 (comment)) so the crater results are kinda useless at that point.

@cuviper @Amanieu: Why wasn't another crater run performed after another impl was added? 🤔

@cuviper
Copy link
Member Author

cuviper commented Dec 24, 2024

I didn't pay much attention myself after handing off to libs-api.

@cuviper cuviper added this to the 1.84.0 milestone Dec 24, 2024
@jieyouxu jieyouxu added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. I-prioritize Issue: Indicates that prioritization has been requested for this issue. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants