Skip to content

x.py test leaves residual files behind #136431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
matthiaskrgr opened this issue Feb 2, 2025 · 5 comments
Open

x.py test leaves residual files behind #136431

matthiaskrgr opened this issue Feb 2, 2025 · 5 comments
Labels
A-compiletest Area: The compiletest test runner C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@matthiaskrgr
Copy link
Member

Running ./x.py test --skip debuginfo-lldb leaves a bunch of residual files in /tmp/ on each run

rustdoctestpqiBsk
rustdoctestoXwyLP
rustdoctest8CBFTK
rustdoctestCLk1vY
rustdoctestlMVB5z
rustdoctestbi58j1
rustdoctest3scGmu
rustdoctestY3FCPW
rustdoctestKGZY7v
rustdoctestgKgSE0
rustdoctestKL4eyN
rustdoctestGS99pq
rustdoctest1XKHuA
rustdoctest0EUbfh
rustdoctestbgoNmD
rustdoctest1fvcau
rustdoctestHzvwPo
rustdoctestytTvTj
rustdoctestelpZO0
rustdoctestSbQSJe
rustdoctestbA0L3M
rustdoctestmCzsMa
@matthiaskrgr matthiaskrgr added A-compiletest Area: The compiletest test runner C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 2, 2025
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Feb 2, 2025
@jieyouxu jieyouxu added E-needs-investigation Call for partcipation: This issues needs some investigation to determine current status and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Feb 2, 2025
@bjorn3
Copy link
Member

bjorn3 commented Feb 2, 2025

When a rustc invocation fails at the right place, it doesn't clean up it's temporary files.

@matthiaskrgr
Copy link
Member Author

all the tests that were run passed and the testsuite exited successfully in this run

@bjorn3
Copy link
Member

bjorn3 commented Feb 2, 2025

Some tests are testing that an error happens.

@jieyouxu jieyouxu added C-enhancement Category: An issue proposing an enhancement or a PR with one. and removed C-bug Category: This is a bug. E-needs-investigation Call for partcipation: This issues needs some investigation to determine current status labels Feb 2, 2025
@matthiaskrgr
Copy link
Member Author

Ah I thought you were referring to the entire testsuite exiting with an error or being ctrl+c'd

I'm not sure if this is a useful approach but perhaps we could create something like a "global" tempdir where we create all the other tempdirs in to have a little more control. We can then clean up our global tempdir at the end of the run when we want to.

@jieyouxu
Copy link
Member

jieyouxu commented Jun 3, 2025

@matthiaskrgr can you check if #140706 fixes this for you?

@jieyouxu jieyouxu added C-bug Category: This is a bug. and removed C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-compiletest Area: The compiletest test runner C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@matthiaskrgr @bjorn3 @jieyouxu @rustbot