Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove rls support #3316

Closed
rbtcollins opened this issue Apr 11, 2023 · 4 comments
Closed

remove rls support #3316

rbtcollins opened this issue Apr 11, 2023 · 4 comments
Labels
Milestone

Comments

@rbtcollins
Copy link
Contributor

rbtcollins commented Apr 11, 2023

With rust-analyzer taking over, should we remove the rls specific tests, and/or the rls proxy?

@mattheww
Copy link

mattheww commented Oct 7, 2023

The rls proxy is something of an active nuisance.

In its default configuration in emacs 29, eglot knows that both rls and rust-analyzer exist, sees that both are available on PATH, and prompts the user rather than just choosing to run rust-analyzer.

@lnicola
Copy link
Member

lnicola commented Oct 7, 2023

I'd blame that on eglot, it shouldn't be trying to run rls. Consider filing an issue there.

(That's not to say the RA proxy itself isn't annoying if you compile your own RA, but it's the best way we have to make rustup-managed RA work. But that's a completely different topic.)

@mattheww
Copy link

mattheww commented Oct 7, 2023

Eglot upstream removed the reference to rls from its default configuration some months ago, but of course it takes time for these things to filter through to users, and there may well be other clients out there in a similar position.

@rami3l
Copy link
Member

rami3l commented Oct 6, 2024

I believe all work required in this repo has concluded in #3920. As such, I'm closing this issue as completed now. For further work, please refer to rust-lang/rust#126856.

@rami3l rami3l closed this as completed Oct 6, 2024
@rami3l rami3l modified the milestones: On Deck, 1.28.0 Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants
@lnicola @mattheww @rbtcollins @rami3l and others