Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipboard copy icon misaligned on Safari #3512

Closed
mistydemeo opened this issue Oct 16, 2023 · 5 comments · Fixed by #3696
Closed

Clipboard copy icon misaligned on Safari #3512

mistydemeo opened this issue Oct 16, 2023 · 5 comments · Fixed by #3696
Labels

Comments

@mistydemeo
Copy link

Problem

On Safari (macOS and iOS), the clipboard copy icon is misaligned. It clips halfway through the top of the button instead of being in the centre. I'm using macOS 14.0 and iOS 17.0.3.

image

Steps

  1. View rustup.rs using Safari

Possible Solution(s)

No response

Notes

No response

Rustup version

N/A

Installed toolchains

N/A
@mistydemeo mistydemeo added the bug label Oct 16, 2023
@djc
Copy link
Contributor

djc commented Oct 24, 2023

This looks like a WebKit bug, maybe https://bugs.webkit.org/show_bug.cgi?id=202588? The code lives at https://github.com/rust-lang/rustup/blob/master/www/index.html#L55 if anyone wants to take a whack at coming up with a more compatible solution.

@rami3l
Copy link
Member

rami3l commented Jan 17, 2024

@mistydemeo May I know what page you were on? I saw this on my iPad today with https://www.rust-lang.org/tools/install:

image

... maybe the style has changed since?


Update: Never mind, I found out: https://rustup.rs.

@noirgif
Copy link
Contributor

noirgif commented Mar 11, 2024

The fix in #3696 does not seem to reflect in the web page yet. So I think this should be left open for now.

@rami3l
Copy link
Member

rami3l commented Mar 11, 2024

@noirgif Indeed, but there is nothing more we can do about it except waiting for the new release to happen in #3501 (we do not get to control what's on rustup.rs right now, which is the responsibility of the release team).

And OTOH we should not track this issue with #3501 since if we did that it would be tracking too many issues.

@noirgif
Copy link
Contributor

noirgif commented Mar 11, 2024

If the deployment does not happens with the merge, but with a new release, then it makes sense to close this issue. Thanks for the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants