Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustbot failed to ping people in a PR #1723

Open
RalfJung opened this issue Sep 20, 2023 · 6 comments
Open

rustbot failed to ping people in a PR #1723

RalfJung opened this issue Sep 20, 2023 · 6 comments
Labels
A-mentions Area: PR auto mentions bug Something isn't working needs reproduction The reproduction steps are unclear

Comments

@RalfJung
Copy link
Member

In rust-lang/rust#115972 rustbot should have pinged some people due to the files that were changed (mentions rules), but somehow that didn't happen. I would understand if it missed the PR entirely due to github not running the hook or whatever, but it did auto-assign a reviewer, so clearly the PR was visible -- it just somehow skipped the part where it is supposed to ping people.

@apiraino
Copy link
Contributor

After you force-pushed pings were fired. I wonder if it was just a spurious hiccup (either on the github end or the triagebot), even though the autoassignment worked (as you correctly point out). Perhaps the triagebot logs might give more insights.

Did something like that happened in the past? (just curious)

@ehuss ehuss added the A-mentions Area: PR auto mentions label Oct 30, 2023
@ehuss ehuss added needs reproduction The reproduction steps are unclear bug Something isn't working labels Jan 21, 2024
@RalfJung
Copy link
Member Author

The same happened again in rust-lang/rust#127907: the PR mutates builtin derives, but no ping for that was done on PR creation, nor on the first force-push. The second force-push a few days later then triggered that ping.

(I've seen this more often but I don't always report that here.)

@RalfJung

This comment has been minimized.

@RalfJung

This comment has been minimized.

@ehuss
Copy link
Contributor

ehuss commented Nov 5, 2024

Which mentions would you have expected those PRs to trigger?

@RalfJung

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-mentions Area: PR auto mentions bug Something isn't working needs reproduction The reproduction steps are unclear
Projects
None yet
Development

No branches or pull requests

3 participants